Skip to content

Add C# examples to Using NavigationRegions #9813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2024
Merged

Add C# examples to Using NavigationRegions #9813

merged 1 commit into from
Aug 23, 2024

Conversation

@sighpher
Copy link
Contributor

@sighpher sighpher commented Aug 23, 2024

Add C# examples to Using NavigationRegions

@AThousandShips AThousandShips requested a review from smix8 August 23, 2024 12:42
@AThousandShips AThousandShips added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:navigation labels Aug 23, 2024
AThousandShips
AThousandShips reviewed Aug 23, 2024
View reviewed changes
raulsntos
raulsntos requested changes Aug 23, 2024
View reviewed changes
raulsntos
raulsntos reviewed Aug 23, 2024
View reviewed changes
@sighpher @AThousandShips @raulsntos
Add C# examples to Using NavigationRegions
6a68d3e 
Co-authored-by: A Thousand Ships <[email protected]>
Co-authored-by: Raul Santos <[email protected]>
raulsntos
raulsntos approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@sighpher
Copy link
Contributor Author

sighpher commented Aug 23, 2024

Looks good to me, thanks!

Awesome thanks @AThousandShips @raulsntos @smix8 for taking the time to review, I have squashed the commits 🥳

@AThousandShips
Copy link
Member

AThousandShips commented Aug 23, 2024

I would suggest not opening any more separate PRs if you have cases but combine all into one remaining PR, these are tiny changes while important and it makes it a lot easier to review and follow up, they don't need separate PRs

@sighpher
Copy link
Contributor Author

sighpher commented Aug 23, 2024

I would suggest not opening any more separate PRs if you have cases but combine all into one remaining PR, these are tiny changes while important and it makes it a lot easier to review and follow up, they don't need separate PRs

No problem, I'll consolidate any further changes into a single PR. I was aiming to keep the changes small and focused, but totally understand making the review process smoother 😎🥳. Thanks for the feedback!

@AThousandShips AThousandShips merged commit 69fe8f0 into godotengine:master Aug 23, 2024
@AThousandShips
Copy link
Member

AThousandShips commented Aug 23, 2024

Thanks!

@sighpher sighpher deleted the update-using-navigation-regions-csharp branch August 23, 2024 16:54
@mhilbrunner
Copy link
Member

mhilbrunner commented Oct 4, 2024

Cherry-picked to 4.3 in #10038.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raulsntos raulsntos raulsntos approved these changes

@smix8 smix8 smix8 approved these changes

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees

No one assigned

Labels

area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.1 cherrypick:4.2 enhancement topic:navigation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sighpher @AThousandShips @mhilbrunner @raulsntos @smix8