Skip to content

Conversation

@sighpher
Copy link
Contributor

Add C# examples to Playing videos

@AThousandShips AThousandShips added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:animation labels Aug 23, 2024
@AThousandShips AThousandShips requested a review from a team August 23, 2024 15:25
@AThousandShips AThousandShips changed the title Add C# examples to Playing videos Add C# example to Playing videos Aug 23, 2024
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also noticed the code block in the Writing the Custom Shader section uses gd but it looks like we use glsl for shaders everywhere else. We may want to change it while we're updating this page.

@sighpher
Copy link
Contributor Author

I also noticed the code block in the Writing the Custom Shader section uses gd but it looks like we use glsl for shaders everywhere else. We may want to change it while we're updating this page.

Great catch! ill update that too 😎

@sighpher sighpher requested a review from raulsntos August 23, 2024 19:11
Co-authored-by: A Thousand Ships <[email protected]>
Co-authored-by: Raul Santos <[email protected]>
@sighpher sighpher requested a review from raulsntos August 24, 2024 10:24
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@AThousandShips AThousandShips merged commit 6b1bd26 into godotengine:master Aug 24, 2024
@AThousandShips
Copy link
Member

Thanks!

@sighpher sighpher deleted the update-playing-videos-csharp branch August 24, 2024 12:28
@mhilbrunner
Copy link
Member

Cherry-picked to 4.3 in #10038.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.1 cherrypick:4.2 enhancement topic:animation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants