-
-
Notifications
You must be signed in to change notification settings - Fork 24
Add .gitignore, fix build on master
#34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
master
# C/C++ generated | ||
*.a | ||
*.ax | ||
*.d | ||
*.dll | ||
*.lib | ||
*.lo | ||
*.o | ||
*.os | ||
*.ox | ||
*.Plo | ||
*.so | ||
# Binutils tmp linker output of the form "stXXXXXX" where "X" is alphanumeric | ||
st[A-Za-z0-9][A-Za-z0-9][A-Za-z0-9][A-Za-z0-9][A-Za-z0-9][A-Za-z0-9] | ||
|
||
# Python generated | ||
__pycache__/ | ||
*.pyc | ||
|
||
# Temporary files. | ||
*.tmp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tentative change, copied a few sections from godotengine/godot, and added .tmp on the bottom, since that was the only other file being generated on my end.
(This review shows the whole file, FYI)
Do you want to merge this in now or after restoring cicd? |
Before cicd would be better, that way the checks will pass as long as configuration is correct (and no additional incompatibilities) |
Can you write up how you generated this? It's not only useful for me to test the change but also as an introduction guide. Also a how to test guide. I assume it's something like use |
Didn't generate anything, all these changes are manual (gitignore is copied though) |
I checked the latest master. It's broken
|
Pull godotengine/godot, CMD_OR_CTRL was implemented in godotengine/godot#65241 14 hours ago |
Looks good to me. |
Fixes incompatibilities introduced in godotengine/godot#64757, godotengine/godot#65039, godotengine/godot#65241, godotengine/godot#65361