Audio samples leaks

[blam23]

Tested versions

• Reproducible in 4.3-stable, 4.3beta2, and 4.3beta3
• Does not occur in 4.3beta1, or 4.2.2-stable

System information

Godot v4.3.stable - Windows 10.0.22631 - GLES3 (Compatibility) - NVIDIA GeForce RTX 3080 Ti (NVIDIA; 31.0.15.5161) - AMD Ryzen 9 5900X 12-Core Processor (24 Threads)

Issue description

Playing an AudioStream in a web build in 4.3 causes objects to be created that are not freed. A windows build of the same code doesn't cause the same leaks. I could not reproduce this with 4.3beta1, only the release 4.3 build (v4.3.stable.official [77dcf97]).

In games with lots of audio, this will lead to an eventual crash when the object count gets too high for the wasm/webgl buffer code to handle.

Steps to reproduce

Create any kind of AudioStream node, and call play on it.
On web, the object count goes up and never goes back down. Check using Performance.OBJECT_COUNT.

Minimal reproduction project (MRP)

MRP: web-leak-repro.zip

I've uploaded this to itch here with debug symbols and gdscript as text: https://blambear.itch.io/godot-web-audio-leak-bug the password is godot.

You can see the object count keep going up and up.

(Note the pop.mp3 file in here is an audio file I recorded, it's MIT licensed)

[blam23]

Examples below of crash error output when the object count gets too high, for me this happens when the object count hits around 50k.

Firefox

Uncaught TypeError: WebGL2RenderingContext.bufferData: Argument 2 can't be an ArrayBuffer or an ArrayBufferView larger than 2 GB

Chrome

index.js:474 USER ERROR: Parameter "mem" is null.
index.js:474 USER ERROR: Out of memory

[blam23]

Tried with 4.3beta2 and 4.3beta3, both seem to reproduce the issue with the object count going up and up. So it seems the issue was introduced between beta1 and beta2.

[akien-mga]

4.3-beta2 is the release where audio sample playback was added for the web platform, so that's probably where the bug originates.

[wheatear-dev]

4.3-beta2 is the release where audio sample playback was added for the web platform, so that's probably where the bug originates.

I can reproduce on 4.3-beta1 😅

My specs:

• MacOS Sonoma 14.6.1 (23G93)
• Chrome Version 128.0.6613.85 (Official Build) (arm64)

The only possible confounding variable is that I exported all 3 tested betas (1, 2, and 3) from 4.3-stable.

EDIT - I didn't wait long enough for it to crash though 😄

Screen.Recording.2024-08-30.at.13.27.57.mov

[akien-mga]

The only possible confounding variable is that I exported all 3 tested betas (1, 2, and 3) from 4.3-stable.

This isn't supported, you'd be mixing incompatible binaries and JS code.

Please make sure to use the same editor version as the export templates you're using.

[RainbowCemetery]

changing the audiostreamplayer playback type to sample has the same leaked object behavior when run in the editor

[blam23]

Just for reference, I've uploaded versions exported from 4.3-beta1 and 4.3beta-2 to itch.io:

https://blambear.itch.io/web-leak-test-4-3-beta1
https://blambear.itch.io/web-leak-test-4-3-beta2

Password for both is again godot.

On my machine, in Firefox (131.0a1) and Chrome (128.0.6613.86), I get a stable object count in beta1 and a consistently increasing object count in beta2.