Skip to content

[WebRTC] Static extension registration. #61839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2022
Merged

[WebRTC] Static extension registration. #61839

merged 1 commit into from
Jun 13, 2022

Conversation

@Faless
Copy link
Collaborator

@Faless Faless commented Jun 9, 2022

Move WebRTC extension registration from WebRTCPeerConnectionExtension to a static method of WebRTCPeerConnection.

This let the official WebRTC plugin register without having to instantiate itself.

@Faless Faless added this to the 4.0 milestone Jun 9, 2022
@Faless Faless requested a review from a team as a code owner June 9, 2022 05:18
@Faless Faless mentioned this pull request Jun 9, 2022
Merged
5 tasks
@fire fire requested a review from a team June 13, 2022 15:14
akien-mga
akien-mga approved these changes Jun 13, 2022
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@akien-mga akien-mga merged commit 133d291 into godotengine:master Jun 13, 2022
@akien-mga
Copy link
Member

akien-mga commented Jun 13, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees

No one assigned

Labels

enhancement topic:gdextension topic:network

Projects

None yet

Milestone

4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Faless @akien-mga