Fix unordered values of PROPERTY_HINT_INT_IS_POINTER & ARRAY_TYPE

[Mickeon]

See comment #67688 (comment),

Switches PROPERTY_HINT_INT_IS_POINTER and PROPERTY_HINT_ARRAY_TYPE around, so that 40 comes before 41 .

Note that the alternative solution could've been to instead switch the BIND_CONSTANTs, but the order it used feels slightly more appropriate. I'm aware that one day of beta could be used to order the enum constants, however.

[bruvzg]

Is it a cosmetic change, or order matter somewhere (AFAIK, it should not)? Property hint raw integer values can be serialized by editor plugins, in the Array hint strings, and used by GDExtensions, so it's a breaking change.

[Mickeon]

It's a "breaking change" specifically for these two constants only, but these property hints did not even exist in Godot 3.x, nor they have any documentation (just yet) to back them up. You can make of that what you will.

If one wants to avoid... this without any breaking at all:

It would simply require shuffling these the two bindings around, which were written under the assumption of it being the intended order:

godot/core/core_constants.cpp

Lines 608 to 612 in 72b845b

	BIND_CORE_ENUM_CONSTANT(PROPERTY_HINT_GLOBAL_SAVE_FILE);
	BIND_CORE_ENUM_CONSTANT(PROPERTY_HINT_INT_IS_OBJECTID);
	BIND_CORE_ENUM_CONSTANT(PROPERTY_HINT_INT_IS_POINTER);
	BIND_CORE_ENUM_CONSTANT(PROPERTY_HINT_ARRAY_TYPE);
	BIND_CORE_ENUM_CONSTANT(PROPERTY_HINT_LOCALE_ID);

[mhilbrunner]

Approved in today's PR meeting

[akien-mga]

Thanks!