Skip to content

Conversation

@fire
Copy link
Member

@fire fire commented Jan 14, 2023

Fixes: #63862

Convert mesh instance 3d to a mesh importer instance 3d. Multi mesh is not converted.

Restore ESCN to a working state even if the Blender importer is slower to be updated.

Restores the tscn to escn usecase.

godotengine/godot-docs#6603

Test Plan

  1. take the fox from Renaming a TSCN to ESCN doesn't regenerate lods #63862 or anywhere else
  2. clear inheritance
  3. save as different tscn
  4. rename that tscn to escn
  5. check that the lod works by setting it to lod property to 0 and compare.

@fire
Copy link
Member Author

fire commented Jan 14, 2023

Blend Shape Test Plan

  1. take the asset from https://github.com/KhronosGroup/glTF-Sample-Models/blob/master/2.0/AnimatedMorphCube/glTF-Binary/AnimatedMorphCube.glb or anywhere else
  2. clear inheritance
  3. save as different tscn
  4. rename that tscn to escn
  5. check that the lod works by setting it to lod property to 0 and compare.

Convert mesh instance 3d to a mesh importer instance 3d to run importer code. Also does blend shapes.
@fire fire marked this pull request as draft January 14, 2023 18:00
@fire fire marked this pull request as ready for review January 14, 2023 18:03
@akien-mga akien-mga merged commit 7fb1b11 into godotengine:master Feb 1, 2023
@akien-mga
Copy link
Member

Thanks!

@fire fire deleted the escn-fixes branch February 1, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Renaming a TSCN to ESCN doesn't regenerate lods

3 participants