Implement 2D instance uniforms

[paddy-exe]

Adds support for 2d instance shader parameters. Cherrypicked the original PR as first commit.

Supersedes #97058
Fixes #62943

Also works with use_parent_material:

Testing project (taken from original PR):
test_pr_97058.zip

[akien-mga]

Can you link that original PR? Is this new PR meant to supersede it, or it's a follow-up and KoBeWi's PR needs to be merged first?

[paddy-exe]

Can you link that original PR? Is this new PR meant to supersede it, or it's a follow-up and KoBeWi's PR needs to be merged first?

It's the follow-up PR to #97058 but it is in VERY early stages. I am trying to wrap my head around the code. Clay gave me instructions on how it could be done for the compatability renderer. All the rest is already done

[clayjohn]

I started writing up what to do, then I realized it was less work for me to just show you, so here is a patch that gets 2D instance uniforms working in 2D.

0001-Finish-GLES3-support.patch

The final piece before this is ready is getting it to work with the "use_parent_material" property. CanvasItems often inherit the material from their parent. Currently it mostly works, but the editor doesn't expose the instance property for updating so you can't set the instance uniform in the editor.

[paddy-exe]

I started writing up what to do, then I realized it was less work for me to just show you, so here is a patch that gets 2D instance uniforms working in 2D.

0001-Finish-GLES3-support.patch

The final piece before this is ready is getting it to work with the "use_parent_material" property. CanvasItems often inherit the material from their parent. Currently it mostly works, but the editor doesn't expose the instance property for updating so you can't set the instance uniform in the editor.

Thank you! I applied your patch except for this part as I couldn't figure out where this goes:

material_storage->shaders.canvas_shader.version_set_uniform(CanvasShaderGLES3::SPECULAR_SHININESS_IN, state.canvas_instance_batches[i].specular_shininess, shader_version, variant, specialization);

[paddy-exe]

Updated with all feedback. Once the code changes are approved I will squash them so we have one commit at the end. The current two commits are for easier checking of the changes I made versus the previous authors made.

Will need to put all previous authors in the commit description as well

[Mickeon]

I would also suggest touching on the descriptions of the equivalent methods for instance geometry, so that they're consistent with the ones added in this PR (which are slightly better formatted). But it doesn't have to be done in this PR.

[Calinou]

Tested locally, it works as expected in all rendering methods.

Testing project: test_pr_99230.zip

[huwpascoe]

I'd like to test this, is it possible to get those conflicts resolved?

[paddy-exe]

@huwpascoe Conflicts resolved.

Be aware that currently the editor doesn't show the parent material properties when use_parent_material is enabled. Still working on that part.

[huwpascoe]

Be aware that currently the editor doesn't show the parent material properties when use_parent_material is enabled. Still working on that part.

I didn't even know that was a feature....well I remember enough about my own work to fix that!

@paddy-exe Here is a patch that implements the parent materials.
0001-implement-use_parent_material.patch

[paddy-exe]

Alright, patch applied. Works great. Thank you for the assistance with this @huwpascoe. Squashed into one commit. Adjusted the code to AThousandShip's codestyle feedback.

[clayjohn]

Looks good to me. Tested locally and confirmed it is still working including with use_parent_material. I think it is ready to merge to get broader testing!!

[Repiteo]

Thanks!