AUTHORS: missing Oracle

[4ad]

The AUTHORS file seems to be missing some corporate sponsors. E.g. Oracle is not there.

Canonical also is not there, although I don't know if it should be there or not.

[ianlancetaylor]

@bradfitz did your generation of the CONTRIBUTORS file do anything for corporate AUTHORS?

[bradfitz]

My script adds corporations, if the email address in git/Gerrit maps to a corporate CLA. @4ad, which commits or email addresses in question do not have corporate attribution?

[4ad]

My script adds corporations, if the email address in git/Gerrit maps to a corporate CLA.

That logic is not correct, at least to my understanding.

This is from a private discussion with @rsc:

It is unclear whether I should use my corporate e-mail or my personal
e-mail for corporate changes [...]

The Go project doesn't have a preference which email address you
use. It is fine to use your personal email for all, or vice versa.
[...] as long as they (corporations) have completed a CLA with us
and put your name on it, we're good. And there's no need to identify
each CL as one copyright holder or the other.

[bradfitz]

Maybe that was true before Gerrit started enforcing the CLA.

Don't submit code to Gerrit (even for review) using your personal email address which is owned by corporations, until that corporation is in our AUTHORS files.

Which companies have you worked for which we now have to retroactively add to AUTHORS? I'll verify they have CLAs on file.

[4ad]

FWIW, this discussion was after the move to Gerrit.

I already mentioned, Oracle.

[bradfitz]

You also mentioned Canonical. Does Canonical own any of your contributions?

[4ad]

No, Canonical does not own any of my contributions.

However, many Canonical employees (@davecheney, @mwhudson) made significant contributions to Go. It made sense to question whether they (Canonical) should be there or not. I have no idea what the arrangement is in place there, it just seemed sensible to mention.

[bradfitz]

Can you clarify which commits or directories or topics of commits written by Aram Hăvărneanu <*@mgk.ro> are owned by Oracle?

[bradfitz]

Presumably stuff about the Solaris port? e.g. db8d5b7 (one example of many, but the only one which mentions Oracle by name in the commit message)

[gopherbot]

CL https://golang.org/cl/14380 mentions this issue.

[binarycrusader]

Don't submit code to Gerrit (even for review) using your personal email address which is owned by corporations, until that corporation is in our AUTHORS files.

There is nothing about waiting until that corporation is in the AUTHORS file on the contribution guidelines page. In fact, it states that These files will be periodically updated based on the commit logs.: http://golang.org/doc/contribute.html

Can you clarify which commits or directories or topics of commits written by Aram Hăvărneanu *@mgk.ro are owned by Oracle?

I will let Aram confirm his own, but all of mine were submitted using an oracle.com email address and for which a CLA was in place at the time they were submitted (Gerrit won't let you upload review until CLA is in place, I know this from experience). But to be explicit those are:

From golang/go:

commit 4f74de1e4d8ac8382d866d9918059144218da069
Author: Shawn Walker-Salas <shawn.walker@...>
Date:   Wed Aug 26 15:24:41 2015 -0700
cmd/go: fix Go buildid reading on Solaris

commit d9e3d16796927ae2c5721cdff855ddb07a903d78
Author: Shawn Walker-Salas <shawn.walker@...>
Date:   Thu Jul 30 13:32:55 2015 -0700
runtime, syscall: remove unused bits from Solaris implementation

From x/sys/unix:

commit 339fc2ca4bac09124d756f897fb8698e26b5a844
Date:   Thu Aug 6 19:57:13 2015 -0700
Author: Shawn Walker-Salas <shawn.walker@...>
unix: update to use direct linking on Solaris

[4ad]

No good deed goes unpunished.

a77fcb3 net: fix comment in sendFile
b0e71f4 net: link with networking libraries when net package is in use
92e959a syscall, net: use sendfile on Solaris
db8d5b7 net: try to fix setKeepAlivePeriod on Solaris
fe5ef5c runtime, syscall: link Solaris binaries directly instead of using dlopen/dlsym
2b90c3e go/build: enable cgo by default on solaris/amd64
2d18ab7 doc/progs: disable cgo tests that use C.Stdout on Solaris
2230e9d misc/cgo: add various solaris build lines
649c7b6 net: add cgo support for Solaris
24396da os/user: small fixes for Solaris
121489c runtime/cgo: add cgo support for solaris/amd64
83b25d9 cmd/ld: make .rela and .rela.plt sections contiguous
c94f1f7 runtime: always load address of libcFunc on Solaris
e481aac cmd/6l: use .plt instead of .got on Solaris