x/mod/zip: TestVCS failures without useful output

[gopherbot]

#!watchflakes
post <- pkg == "golang.org/x/mod/zip" && test == "TestVCS" && date < "2023-01-01"

Bug automatically created to track these flakes.

— watchflakes

[gopherbot]

Found new matching flaky dashboard failures for:

#!watchflakes
post <- pkg == "golang.org/x/mod/zip" && test == "TestVCS"

2022-09-07 13:59 linux-amd64-longtest mod@02c99138 go@4c414c76 golang.org/x/mod/zip.TestVCS (log)

--- FAIL: TestVCS (0.00s)
    --- FAIL: TestVCS/golang.org_x_net@v0.0.0-20191014212845-da9a3fd4c582 (131.80s)
        zip_test.go:1279: failed to download zip from repository (repeated failure): fetch -f --depth=1 origin da9a3fd4c5820e74b24a6cb7fb438dc9b0dd377c:refs/dummy: exit status 128
hint: Using 'master' as the name for the initial branch. This default branch name
hint: is subject to change. To configure the initial branch name to use in all
hint: of your new repositories, which will suppress this warning, call:
hint: 
hint: 	git config --global init.defaultBranch <name>
hint: 
hint: Names commonly chosen instead of 'master' are 'main', 'trunk' and
...
hint: Using 'master' as the name for the initial branch. This default branch name
hint: is subject to change. To configure the initial branch name to use in all
hint: of your new repositories, which will suppress this warning, call:
hint: 
hint: 	git config --global init.defaultBranch <name>
hint: 
hint: Names commonly chosen instead of 'master' are 'main', 'trunk' and
hint: 'development'. The just-created branch can be renamed via this command:
hint: 
hint: 	git branch -m <name>

— watchflakes

[bcmills]

The root cause of this is likely #50541, but the test should be fixed to log the actual failures instead of (just) “repeated failure”.

[gopherbot]

Change https://go.dev/cl/432475 mentions this issue: zip: expand logging and use t.TempDir and t.Cleanup in test helpers

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/mod/zip" && test == "TestVCS"

2023-05-17 15:46 linux-amd64-longtest-race mod@e7bea8f1 go@5ffdc1f1 x/mod/zip.TestVCS (log)

--- FAIL: TestVCS (0.00s)
    --- FAIL: TestVCS/golang.org_x_talks@v0.0.0-20191010201600-067e0d331fee (83.65s)
        zip_test.go:1327: /usr/bin/git init --bare
        zip_test.go:1344: /usr/bin/git remote add origin -- https://go.googlesource.com/talks
        zip_test.go:1353: exit status 128: /usr/bin/git fetch -f --depth=1 origin 067e0d331feee4f8d0fa17d47444db533bd904e7:refs/dummy
            15:57:10.432027 http.c:756              == Info: Couldn't find host go.googlesource.com in the .netrc file; using defaults
            15:57:10.436145 http.c:756              == Info:   Trying 209.85.147.82:443...
            15:57:10.437204 http.c:756              == Info: Connected to go.googlesource.com (209.85.147.82) port 443 (#0)
            15:57:10.494546 http.c:756              == Info: found 387 certificates in /etc/ssl/certs
            15:57:10.494641 http.c:756              == Info: ALPN, offering h2
...
            15:58:34.047371 http.c:703              <= Recv header, 0000000021 bytes (0x00000015)
            15:58:34.047373 http.c:715              <= Recv header: x-xss-protection: 0
            15:58:34.047376 http.c:703              <= Recv header, 0000000037 bytes (0x00000025)
            15:58:34.047378 http.c:715              <= Recv header: date: Tue, 23 May 2023 15:58:34 GMT
            15:58:34.047382 http.c:703              <= Recv header, 0000000002 bytes (0x00000002)
            15:58:34.047385 http.c:715              <= Recv header:
            15:58:34.047432 http.c:756              == Info: Connection #0 to host go.googlesource.com left intact
            error: RPC failed; HTTP 502 curl 22 The requested URL returned error: 502
            fatal: error reading section header 'shallow-info'
        zip_test.go:1222: failed to download zip from repository (repeated failure): exit status 128

— watchflakes