Fix: Handle undefined properties in onUpdateEvent to prevent streaming crashes #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g crashes - Add safe fallbacks for undefined query_list and follow_up_queries arrays - Prevent TypeError when properties are undefined during event processing - Ensure streaming flow continues even with malformed events - Add fallback UI for empty message content
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
should be fixed in #109 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The frontend streaming would crash when
event.generate_query.query_listorevent.reflection.follow_up_querieswere undefined, causing a TypeError that broke the entire event processing pipeline. This resulted in the UI showing "No response received" even though the backend was working correctly and generating proper responses.Error occurred:
TypeError: Cannot read properties of undefined (reading 'join')
This prevented the
finalize_answerevent from being processed, leaving users with empty AI responses despite successful backend processing.