Skip to content

Add @CheckReturnValue to our packages. #2693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 1, 2024
Merged

Add @CheckReturnValue to our packages. #2693

merged 2 commits into from
Jun 1, 2024

Conversation

cpovirk
Copy link
Member

@cpovirk cpovirk commented May 31, 2024

...as threatened in
#2676 (comment).

github-advanced-security[bot]
github-advanced-security bot found potential problems May 31, 2024
View reviewed changes
metrics/src/main/java/com/google/gson/metrics/BagOfPrimitivesDeserializationBenchmark.java
@@ -48,7 +48,7 @@
/** Benchmark to measure Gson performance for deserializing an object */
public void timeBagOfPrimitivesDefault(int reps) {
for (int i = 0; i < reps; ++i) {
gson.fromJson(json, BagOfPrimitives.class);
BagOfPrimitives unused = gson.fromJson(json, BagOfPrimitives.class);

Check notice

Code scanning / CodeQL

Unread local variable

Variable 'BagOfPrimitives unused' is never read.
metrics/src/main/java/com/google/gson/metrics/CollectionsDeserializationBenchmark.java
@@ -56,7 +56,7 @@
/** Benchmark to measure Gson performance for deserializing an object */
public void timeCollectionsDefault(int reps) {
for (int i = 0; i < reps; ++i) {
gson.fromJson(json, LIST_TYPE_TOKEN);
List<BagOfPrimitives> unused = gson.fromJson(json, LIST_TYPE_TOKEN);

Check notice

Code scanning / CodeQL

Unread local variable

Variable 'List<BagOfPrimitives> unused' is never read.
metrics/src/main/java/com/google/gson/metrics/SerializationBenchmark.java
@@ -45,7 +45,7 @@

public void timeObjectSerialization(int reps) {
for (int i = 0; i < reps; ++i) {
gson.toJson(bag);
String unused = gson.toJson(bag);

Check notice

Code scanning / CodeQL

Unread local variable

Variable 'String unused' is never read.
metrics/src/main/java/com/google/gson/metrics/ParseBenchmark.java
@@ -195,19 +196,19 @@
reader.endObject();
break;
case NAME:
reader.nextName();
String unusedName = reader.nextName();

Check notice

Code scanning / CodeQL

Unread local variable

Variable 'String unusedName' is never read.
metrics/src/main/java/com/google/gson/metrics/ParseBenchmark.java
break;
case BOOLEAN:
reader.nextBoolean();
boolean unusedBoolean = reader.nextBoolean();

Check notice

Code scanning / CodeQL

Unread local variable

Variable 'boolean unusedBoolean' is never read.
metrics/src/main/java/com/google/gson/metrics/ParseBenchmark.java
break;
case NULL:
reader.nextNull();
break;
case NUMBER:
reader.nextLong();
long unusedLong = reader.nextLong();

Check notice

Code scanning / CodeQL

Unread local variable

Variable 'long unusedLong' is never read.
metrics/src/main/java/com/google/gson/metrics/ParseBenchmark.java
break;
case STRING:
reader.nextString();
String unusedString = reader.nextString();

Check notice

Code scanning / CodeQL

Unread local variable

Variable 'String unusedString' is never read.
metrics/src/main/java/com/google/gson/metrics/ParseBenchmark.java
@@ -274,7 +275,7 @@
private static class GsonDomParser implements Parser {
@Override
public void parse(char[] data, Document document) throws Exception {
JsonParser.parseReader(new CharArrayReader(data));
JsonElement unused = JsonParser.parseReader(new CharArrayReader(data));

Check notice

Code scanning / CodeQL

Unread local variable

Variable 'JsonElement unused' is never read.
metrics/src/main/java/com/google/gson/metrics/ParseBenchmark.java
@@ -284,7 +285,7 @@

@Override
public void parse(char[] data, Document document) throws Exception {
gson.fromJson(new CharArrayReader(data), document.gsonType);
Object unused = gson.fromJson(new CharArrayReader(data), document.gsonType);

Check notice

Code scanning / CodeQL

Unread local variable

Variable 'Object unused' is never read.
@Marcono1234
Copy link
Collaborator

Marcono1234 commented Jun 1, 2024 •
edited
Loading

Sorry for the incorrect "Check API compatibility" workflow failure. This has been fixed by #2694; please merge main into your branch, that should fix the failure.

Edit: Nevermind, Éamonn was faster and already merged in the fix 😄

@eamonnmcmanus eamonnmcmanus merged commit ce2129e into google:main Jun 1, 2024
This was referenced Jan 30, 2025
Closed
Merged
Merged
Merged
Merged
Merged
@chrisrueger chrisrueger mentioned this pull request Jan 30, 2025
Closed
4 tasks
@kousen kousen mentioned this pull request Jan 31, 2025
Merged
mergify bot added a commit to ArcadeData/arcadedb that referenced this pull request Feb 3, 2025
@mergify
build(deps): bump com.google.code.gson:gson from 2.11.0 to 2.12.1 [sk…
1771c9b 
…ip ci]

Bumps [com.google.code.gson:gson](https://github.com/google/gson) from 2.11.0 to 2.12.1.
Release notes

*Sourced from [com.google.code.gson:gson's releases](https://github.com/google/gson/releases).*

> Gson 2.11.1
> -----------
> 
> The only difference between this release and 2.11.0 is that OSGi declarations in the Gson jar now specify that `com.google.errorprone.annotations` is an optional dependency, not a required one. If you do not use OSGi then there is no effective change.
> 
> Gson 2.12.0
> -----------
> 
> What's Changed
> --------------
> 
> The biggest change is that we no longer support Java 7. People who still need to run on Java 7 will need to use an earlier version of Gson.
> 
> Other changes:
> 
> * Allow registering adapters for `JsonElement` again by [`@​Marcono1234`](https://github.com/Marcono1234) in [google/gson#2789](https://redirect.github.com/google/gson/pull/2789)
> * Add nesting limit for `JsonReader` by [`@​Marcono1234`](https://github.com/Marcono1234) in [google/gson#2588](https://redirect.github.com/google/gson/pull/2588)
> * Add `@CheckReturnValue` to our packages. by [`@​cpovirk`](https://github.com/cpovirk) in [google/gson#2693](https://redirect.github.com/google/gson/pull/2693)
> * Add NullSafeTypeAdapter to prevent TypeAdapter.nullSafe() from returning nested null-safe type adapters ([#2729](https://redirect.github.com/google/gson/issues/2729)) by [`@​lyubomyr-shaydariv`](https://github.com/lyubomyr-shaydariv) in [google/gson#2731](https://redirect.github.com/google/gson/pull/2731)
> * Support Properties subclasses in GsonTypes.getMapKeyAndValueTypes by [`@​panic08`](https://github.com/panic08) in [google/gson#2758](https://redirect.github.com/google/gson/pull/2758)
> * Enforce rawType to be a Class in ParameterizedTypeImpl by [`@​panic08`](https://github.com/panic08) in [google/gson#2759](https://redirect.github.com/google/gson/pull/2759)
> * Remove `AccessController` usage for enum adapter by [`@​Marcono1234`](https://github.com/Marcono1234) in [google/gson#2704](https://redirect.github.com/google/gson/pull/2704)
> * Fix typeArguments array not being cloned when resolving ParameterizedType with changed owner by [`@​TBlueF`](https://github.com/TBlueF) in [google/gson#2706](https://redirect.github.com/google/gson/pull/2706)
> * Remove duplicated declaration of required OSGi execution environment by [`@​HannesWell`](https://github.com/HannesWell) in [google/gson#2711](https://redirect.github.com/google/gson/pull/2711)
> * Move bnd.bnd file configuration into 'bnd' element of bnd-maven-plugin by [`@​HannesWell`](https://github.com/HannesWell) in [google/gson#2712](https://redirect.github.com/google/gson/pull/2712)
> * Move enum and `JsonElement` adapter classes to separate class files by [`@​Marcono1234`](https://github.com/Marcono1234) in [google/gson#2727](https://redirect.github.com/google/gson/pull/2727)
> * EnumTypeAdapter constructor optimization by [`@​esaulpaugh`](https://github.com/esaulpaugh) in [google/gson#2734](https://redirect.github.com/google/gson/pull/2734)
> * OSGi / bnd: Remove the self-Import of gson.annotations by [`@​chrisrueger`](https://github.com/chrisrueger) in [google/gson#2735](https://redirect.github.com/google/gson/pull/2735)
> 
> New Contributors
> ----------------
> 
> * [`@​cpovirk`](https://github.com/cpovirk) made their first contribution in [google/gson#2693](https://redirect.github.com/google/gson/pull/2693)
> * [`@​jabagawee`](https://github.com/jabagawee) made their first contribution in [google/gson#2701](https://redirect.github.com/google/gson/pull/2701)
> * [`@​TBlueF`](https://github.com/TBlueF) made their first contribution in [google/gson#2706](https://redirect.github.com/google/gson/pull/2706)
> * [`@​HannesWell`](https://github.com/HannesWell) made their first contribution in [google/gson#2711](https://redirect.github.com/google/gson/pull/2711)
> * [`@​esaulpaugh`](https://github.com/esaulpaugh) made their first contribution in [google/gson#2734](https://redirect.github.com/google/gson/pull/2734)
> * [`@​chrisrueger`](https://github.com/chrisrueger) made their first contribution in [google/gson#2735](https://redirect.github.com/google/gson/pull/2735)
> * [`@​panic08`](https://github.com/panic08) made their first contribution in [google/gson#2756](https://redirect.github.com/google/gson/pull/2756)
> 
> **Full Changelog**: <google/gson@gson-parent-2.11.0...gson-parent-2.12.0>


Commits

* [`29e3d1d`](google/gson@29e3d1d) [maven-release-plugin] prepare release gson-parent-2.12.1
* [`be456cf`](google/gson@be456cf) Make the import of com.google.errorprone optional ([#2795](https://redirect.github.com/google/gson/issues/2795))
* [`b2e26fa`](google/gson@b2e26fa) Bump the github-actions group with 3 updates ([#2785](https://redirect.github.com/google/gson/issues/2785))
* [`10bdd6d`](google/gson@10bdd6d) Simplify collection type adapters slightly. ([#2791](https://redirect.github.com/google/gson/issues/2791))
* [`ab9c54f`](google/gson@ab9c54f) [maven-release-plugin] prepare for next development iteration
* [`aaf7a12`](google/gson@aaf7a12) [maven-release-plugin] prepare release gson-parent-2.12.0
* [`a2b1c3c`](google/gson@a2b1c3c) Allow registering adapters for `JsonElement` again ([#2789](https://redirect.github.com/google/gson/issues/2789))
* [`e5dce84`](google/gson@e5dce84) Bump the maven group with 8 updates ([#2784](https://redirect.github.com/google/gson/issues/2784))
* [`84e5f16`](google/gson@84e5f16) Bump the maven group with 7 updates ([#2777](https://redirect.github.com/google/gson/issues/2777))
* [`9f3e577`](google/gson@9f3e577) Bump the github-actions group with 2 updates ([#2778](https://redirect.github.com/google/gson/issues/2778))
* Additional commits viewable in [compare view](google/gson@gson-parent-2.11.0...gson-parent-2.12.1)

  

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=com.google.code.gson:gson&package-manager=maven&previous-version=2.11.0&new-version=2.12.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eamonnmcmanus eamonnmcmanus eamonnmcmanus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cpovirk @Marcono1234 @eamonnmcmanus