Skip to content

Adjust Troubleshooting Guide ProGuard / R8 section #2844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Marcono1234
Copy link
Collaborator

Follow-up for #2843

@@ -397,10 +398,18 @@ For backward compatibility it is possible to restore Gson's old behavior of allo
- This does not solve any of the type-safety problems mentioned above; in the long term you should prefer one of the other solutions listed above. This system property might be removed in future Gson versions.
- You should only ever set the property to `"true"`, but never to any other value or manually clear it. Otherwise this might counteract any libraries you are using which might have deliberately set the system property because they rely on its behavior.

## ProGuard / R8
## <a id="proguard-r8"></a> ProGuard / R8
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used a custom anchor here for consistency with the other ones. If we really want to change something about these anchors, then it would be better to do it for all and not just for a single one.

Within GitHub these custom anchors seem to work fine, and also within IntelliJ they work to some extent. See #2843 (comment).

@eamonnmcmanus
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants