[array_simp] Fix bug in array slice chain simplification #2700
+91
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
Rather than just checking if the end index runs off the end of the ultimate base array, we instead check if any intermediate slice can run off the end of the array it's slicing, and truncate the chain if it does. This avoids complications that can occur when slicing "past the end" of an array, which will pad the array with extra copies of the last entry (to stay consistent with `array_index`). Fixes #2692 PiperOrigin-RevId: 787263829
|
Gah, sorry about that. Good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[array_simp] Fix bug in array slice chain simplification
Rather than just checking if the end index runs off the end of the ultimate base array, we instead check if any intermediate slice can run off the end of the array it's slicing, and truncate the chain if it does.
This avoids complications that can occur when slicing "past the end" of an array, which will pad the array with extra copies of the last entry (to stay consistent with
array_index).Fixes #2692