- 
                Notifications
    You must be signed in to change notification settings 
- Fork 128
[ci] Roll pinned nightly toolchain #2745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[ci] Roll pinned nightly toolchain #2745
Conversation
| Summary of ChangesHello @google-pr-creation-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs an automated update to the project's CI configuration, specifically rolling forward the  Highlights
 Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either  
 Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a  Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request automatically updates the pinned nightly Rust toolchain. However, the proposed version nightly-2025-10-26 appears to be an invalid toolchain identifier, which will cause continuous integration builds to fail. I have left a critical comment on the Cargo.toml file detailing this issue. This should be corrected to a valid toolchain version before merging.
| # The versions of the stable and nightly compiler toolchains to use in CI. | ||
| pinned-stable = "1.90.0" | ||
| pinned-nightly = "nightly-2025-10-17" | ||
| pinned-nightly = "nightly-2025-10-26" | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The specified nightly toolchain nightly-2025-10-26 is not a valid, available toolchain. This will cause CI builds that rely on the nightly toolchain to fail. Please update this to a valid, existing nightly toolchain version. This issue may stem from a bug in the automation script that created this pull request.
Automated changes by create-pull-request GitHub action