Rename FromZeroes to FromZeros
#430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jswrenn
commented
Sep 29, 2023
jswrenn
commented
Sep 29, 2023
joshlf
reviewed
Sep 29, 2023
joshlf
requested changes
Sep 29, 2023
Closed
joshlf
requested changes
Dec 7, 2023
joshlf
requested changes
Dec 7, 2023
There was a problem hiding this comment.
Also, can you update the commit message?
- Capitalize "rename" in the summary line
- Mention that "zeroes" is a valid spelling, but that "zeros" is more commonly accepted, possibly citing this StackExchange answer
- Add
Closes #431at the end
jswrenn
force-pushed
the
from-zeros
branch
2 times, most recently
from
c3263b0 to
b9c524b
Compare
joshlf
requested changes
Dec 7, 2023
Although both spellings are acceptable, "zeros" is the somewhat more common [1] spelling of the plural noun "zero". We continue to use the spelling "zeroes" for the verb; i.e., to replace bytes with the value `0`. For user convenience, `FromZeroes` is retained as a deprecated, `doc(hidden)` re-export of `FromZeros`. Closes #431 [1] https://english.stackexchange.com/questions/3824/what-is-the-plural-form-of-zero/3825#3825
joshlf
approved these changes
Dec 7, 2023
jswrenn
commented
Dec 7, 2023
| /// Deprecated: prefer [`FromZeros`] instead. | ||
| #[deprecated(since = "0.8.0", note = "`FromZeroes` was renamed to `FromZeros`")] | ||
| #[doc(hidden)] | ||
| pub use FromZeros as FromZeroes; |
There was a problem hiding this comment.
This is going to use-rename both the trait and the proc macro (if it's in scope from the derive feature).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretend you didn't see this.
FromZeroesis retained as a deprecated,doc(hidden)re-export.Additionally, for consistency,
LayoutVerifiedis changed from a type alias topub use ... as ...reexport.