feat: add cred info to ADC creds #1587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arithmetic1728
force-pushed
the
error
branch
2 times, most recently
from
a886932 to
64b92e2
Compare
arithmetic1728
changed the title
aeitzman
reviewed
Aug 28, 2024
sai-sunder-s
approved these changes
Sep 1, 2024
Contributor
Author
|
@aeitzman Any questions on this PR? If not I am going to merge it. Thanks! |
aeitzman
approved these changes
Sep 11, 2024
aeitzman
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a get_cred_info() method to ADC cred. If the cred comes from google.auth.default() or a copy of such cred, the method returns a JSON to tell the cred file path, cred type and the principal if available. See go/python-auth-error-message-improvement.