Skip to content

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Jan 30, 2016

Also updating system tests and system test helpers to avoid direct use of __key__.

Fixes #1432.

Also updating system tests and system test helpers to
avoid direct use of __key__.

Fixes googleapis#1432.
@dhermes dhermes added the api: datastore Issues related to the Datastore API. label Jan 30, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 30, 2016
They were using the dataset ID environment variable key rather
than the value.
@dhermes
Copy link
Contributor Author

dhermes commented Jan 30, 2016

Also fixed the broken clear_datastore.py and populate_datastore.py helper. I broke them in #1383 #1369

@tseaver
Copy link
Contributor

tseaver commented Jan 30, 2016

LGTM. Are we not-yet-ready-for-primetime on AppVeyor?

@dhermes
Copy link
Contributor Author

dhermes commented Jan 30, 2016

@tseaver I commented on #1318, it introduced a test that fails on Windows. Just filed #1434 about it.

I'd like to turn off AppVeyor for PRs though.

dhermes added a commit that referenced this pull request Jan 30, 2016
Adding key_filter to datastore Query.
@dhermes dhermes merged commit 0910f99 into googleapis:master Jan 30, 2016
@dhermes dhermes deleted the fix-1432 branch January 30, 2016 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants