Skip to content

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Mar 3, 2017

We missed this because it does not use GAPIC (the most recent generated Bigtable GAPIC surface is 5+ months old).


NOTE: This will fail all CI since google-gax==0.15.7 isn't out yet, but I wanted to get reviewers a chance to see it before 0.15.7 gets released tomorrow. (I have personally run the tests locally by installed google-gax from HEAD.)

@dhermes dhermes added api: bigtable Issues related to the Bigtable API. grpc labels Mar 3, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 3, 2017
We missed this because it does not use GAPIC (the most
recent generated Bigtable GAPIC surface is 5+ months old).
@dhermes dhermes force-pushed the bigtable-version-info branch from 374f8c0 to 20ffd2b Compare March 3, 2017 00:57
@dhermes
Copy link
Contributor Author

dhermes commented Mar 3, 2017

@lukesneeringer Builds are green! Thanks for releasing 0.15.7. PTAL, as the gRPC layer for datastore needs the same treatment that this PR gives to Bigtable. (As an easy-to-implement stopgap while #2746 is in progress.)

@dhermes dhermes merged commit aadb25f into googleapis:master Mar 3, 2017
@dhermes dhermes deleted the bigtable-version-info branch March 3, 2017 19:05
@dhermes
Copy link
Contributor Author

dhermes commented Mar 3, 2017

@lukesneeringer Should I cut bigtable-0.23.1?

@lukesneeringer
Copy link
Contributor

Yes, please.

richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
Sending x-goog-api-client header in Bigtable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement. grpc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants