-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Language: Add classify_text method (v1).
#4283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dhermes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursory LGTM
265ef6f to
a9474ee
Compare
|
Okay, I tested this and am happy with it (but need to see what is up with CI). @dhermes, I want to do the following:
How does this interact with the releases you just did? I want to make sure I do not step on your toes. |
|
@lukesneeringer I think it'd be fine to do two releases only (since you don't depend on a new version of
|
0155102 to
fa1d8cd
Compare
|
@dhermes Sounds good. |
* Language: Add `classify_text` method (v1). * Update v1beta2 also.
This PR adds the
classify_textmethod currently in thev1beta2API version to thev1version. This should be held until November 15 (the endpoint will not be live onv1until then).