Making regression3 pass #756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix googleapis/oauth2client#125 was pushed in 1.4.7 release.
- Incorporates changes from googleapis#724. - Also requires httplib2 from HEAD since the bytes/unicode header issues have not been released on PyPI yet.
googlebot
added
the
cla: yes
Contributor
Author
|
@tseaver PTAL |
gcloud/storage/batch.py
Outdated
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
- Adding test for branch miss in credentials._get_signed_query_params - Making storage.batch._unpack_batch_response work correctly in Python2 and Python3 (parser expects str in both) NOTE: Yet again %s caused issues between Py2 and Py3 (as in the PR googleapis#126 in oauth2client).
dhermes
force-pushed
the
oauth2client-use-master
branch
from
1b94f9f to
fdb1d23
Compare
Contributor
|
LGTM, module adding the comment to |
Contributor
Author
|
@tseaver I made a new commit from my phone. PTAL and then I'll merge if Travis passes. |
Contributor
|
LGTM |
Contributor
Author
|
@tseaver should we add |
Contributor
|
SGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oauth2clientwhich incorporates Fixing JSON key service account assertions in Python3. oauth2client#126HEADinhttplib2until Update __init__.py jcgregorio/httplib2#291 and Added unit test for #291 jcgregorio/httplib2#296 are incorporatedstorage.batch._unpack_batch_responseto straddle Py2/Py3. The email nativestrdependency is tricky there.stris insufficient in Py3NOTE: As in googleapis/oauth2client#126, using
%sfor a Py2 and Py3 codebase caused us issues in_unpack_batch_response