Skip to content

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Mar 25, 2015

NOTE: Has #759 as a diffbase.

This is an implementation detail intended to make internal code have an easier time constructing entities, but never had a story for end-users.

The only real changes are effectively:

-            yield Bucket(properties=item, connection=self._ctor_connection)
+            name = item.get('name')
+            bucket = Bucket(name, connection=self._ctor_connection)
+            bucket._properties = item
+            yield bucket

For test conveniences, I've allowed _makeOne() to delegate the properties= keyword in the way it used to be used in the actual constructors.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 25, 2015
@dhermes dhermes added the api: storage Issues related to the Cloud Storage API. label Mar 25, 2015
@dhermes dhermes force-pushed the remove-properties-from-constructor branch from 7ed8baa to 9cd15a6 Compare March 25, 2015 22:35
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9cd15a6 on dhermes:remove-properties-from-constructor into d34a15e on GoogleCloudPlatform:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9cd15a6 on dhermes:remove-properties-from-constructor into d34a15e on GoogleCloudPlatform:master.

@tseaver
Copy link
Contributor

tseaver commented Mar 26, 2015

Changes relative to #759 LGTM.

@dhermes dhermes force-pushed the remove-properties-from-constructor branch from 9cd15a6 to 44e5b74 Compare March 28, 2015 18:01
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 44e5b74 on dhermes:remove-properties-from-constructor into 3906245 on GoogleCloudPlatform:master.

@dhermes
Copy link
Contributor Author

dhermes commented Mar 28, 2015

@tseaver I peeled off the last two commits to separate from #759. Let me know if you're not cool with the merge.

dhermes added a commit that referenced this pull request Mar 28, 2015
Remove properties= from Blob and Bucket constructors
@dhermes dhermes merged commit 622d994 into googleapis:master Mar 28, 2015
@dhermes dhermes deleted the remove-properties-from-constructor branch March 28, 2015 18:04
parthea added a commit that referenced this pull request Oct 21, 2023
* docs: Add documentation for enums

fix: Add context manager return types

chore: Update gapic-generator-python to v1.8.1
PiperOrigin-RevId: 503210727

Source-Link: googleapis/googleapis@a391fd1

Source-Link: googleapis/googleapis-gen@0080f83
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDA4MGY4MzBkZWMzN2MzMzg0MTU3MDgyYmNlMjc5ZTM3MDc5ZWE1OCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* feat: Update Compute Engine API to revision 20221224 (#760)

Source-Link: googleapis/googleapis@17d5613

Source-Link: googleapis/googleapis-gen@42cd552
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDJjZDU1MmZhNWJlOTViZTVjZTUxMzZiYTkzZTgzMzg4Yjc1OTFkOCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* work around docs issue

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Aug 21, 2025
parthea pushed a commit that referenced this pull request Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants