Add implicit environment support to pubsub #763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
9 tasks
Contributor
|
Just reviewed from phone. LGTM. I'm unclear if we need both the Cloud Platform scope and the Pubsub scope (i.e. just one will do). Maybe not though. There are methods in storage where the |
tseaver
added a commit
that referenced
this pull request
Mar 27, 2015
Add implicit environment support to pubsub
Contributor
Author
|
@dhermes the API docs for authorization appear to indicate that either scope would be fine. |
Contributor
|
In my understanding, the Cloud Platform scope contains all of the scopes. I prefer using only Pubsub scope explicitly rather than using the wildcard. |
parthea
pushed a commit
that referenced
this pull request
Aug 21, 2025
* chore: exclude sample-specific formatting from owlbot * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Sep 16, 2025
* chore: exclude sample-specific formatting from owlbot * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Sep 18, 2025
* specify a particular version of bigquery to debug * again tweaking the versions to debug issue. * add some pip freeze commands for debugging * updates minimum latency to correct a flaky bot issue and protect users * Update noxfile.py * Update noxfile.py * Update setup.py * Update noxfile.py * add several test cases to test validation logic * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.