-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Make Blob/Bucket reload() public and remove the public interface to _properties #770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM. My question about |
|
@dhermes needs rebase? |
87b9bf3 to
3817154
Compare
|
@tseaver Rebased and filed the bug about Will merge on Travis success. |
The blob/bucket metadata was never actually accessed via the public properties `properties`.
3817154 to
85aea83
Compare
|
Changes Unknown when pulling 85aea83 on dhermes:make-reload-public into * on GoogleCloudPlatform:master*. |
|
Changes Unknown when pulling 85aea83 on dhermes:make-reload-public into * on GoogleCloudPlatform:master*. |
Make Blob/Bucket reload() public and remove the public interface to _properties
* feat: Update Compute Engine API to revision 20230307 (#770) Source-Link: googleapis/googleapis@c2016e5 Source-Link: googleapis/googleapis-gen@0885fd7 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDg4NWZkN2FlOGE4MDVhMzc3OTc0ZWRmYmE2MGFiN2M5MzI3Zjc1YSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
…770) * fix: export handwritten classes * change init file accordingly * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * correct import path * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix import * fix error * delete a commented out line --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
…770) * fix: export handwritten classes * change init file accordingly * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * correct import path * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix import * fix error * delete a commented out line --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/python-bigquery-pandas/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) 🦕
No description provided.