Skip to content

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Mar 28, 2015

No description provided.

@dhermes dhermes added the api: storage Issues related to the Cloud Storage API. label Mar 28, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 28, 2015
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 87b9bf3 on dhermes:make-reload-public into 4d69bb3 on GoogleCloudPlatform:master.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@tseaver
Copy link
Contributor

tseaver commented Mar 30, 2015

LGTM. My question about return self from mutators shouldn't block the merge, but we should be dropping that pattern pretty much everywhere.

@tseaver
Copy link
Contributor

tseaver commented Mar 30, 2015

@dhermes needs rebase?

@dhermes dhermes force-pushed the make-reload-public branch from 87b9bf3 to 3817154 Compare March 30, 2015 19:29
@dhermes
Copy link
Contributor Author

dhermes commented Mar 30, 2015

@tseaver Rebased and filed the bug about return self.

Will merge on Travis success.

dhermes added 2 commits March 30, 2015 12:41
The blob/bucket metadata was never actually accessed via
the public properties `properties`.
@dhermes dhermes force-pushed the make-reload-public branch from 3817154 to 85aea83 Compare March 30, 2015 19:42
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 85aea83 on dhermes:make-reload-public into * on GoogleCloudPlatform:master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 85aea83 on dhermes:make-reload-public into * on GoogleCloudPlatform:master*.

dhermes added a commit that referenced this pull request Mar 30, 2015
Make Blob/Bucket reload() public and remove the public interface to _properties
@dhermes dhermes merged commit ef22592 into googleapis:master Mar 30, 2015
@dhermes dhermes deleted the make-reload-public branch March 30, 2015 19:59
parthea pushed a commit that referenced this pull request Oct 21, 2023
* feat: Update Compute Engine API to revision 20230307 (#770)

Source-Link: googleapis/googleapis@c2016e5

Source-Link: googleapis/googleapis-gen@0885fd7
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDg4NWZkN2FlOGE4MDVhMzc3OTc0ZWRmYmE2MGFiN2M5MzI3Zjc1YSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Aug 21, 2025
…770)

* fix: export handwritten classes

* change init file accordingly

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* correct import path

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix import

* fix error

* delete a commented out line

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 16, 2025
…770)

* fix: export handwritten classes

* change init file accordingly

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* correct import path

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix import

* fix error

* delete a commented out line

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 18, 2025
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/python-bigquery-pandas/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants