Skip to content

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Mar 28, 2015

Fixes #752.

I realize there was never any discussion in #752, but here is my argument for this:

The constructors have a tiny memory footprint and make no HTTP request.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 28, 2015
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 935c612 on dhermes:fix-752 into 4d69bb3 on GoogleCloudPlatform:master.

@dhermes dhermes added the api: storage Issues related to the Cloud Storage API. label Mar 29, 2015

This comment was marked as spam.

This comment was marked as spam.

@tseaver
Copy link
Contributor

tseaver commented Mar 30, 2015

LGTM

dhermes added a commit that referenced this pull request Mar 30, 2015
Ditching lazy loading for ACLs attached to Blob/Bucket.
@dhermes dhermes merged commit 4e64267 into googleapis:master Mar 30, 2015
@dhermes dhermes deleted the fix-752 branch March 30, 2015 19:20
parthea pushed a commit that referenced this pull request Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DISCUSSION: Do we need ACL lazy loading?

4 participants