Skip to content

Conversation

@diegomarquezp
Copy link
Contributor

@diegomarquezp diegomarquezp commented Mar 24, 2025

googleapis/java-shared-config#1003 was merged in java-shared-config and will bring the latest google-java-format formatter to this repository.

This PR contains:

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/java-bigquery API. labels Mar 24, 2025
@diegomarquezp diegomarquezp marked this pull request as ready for review March 24, 2025 15:29
@diegomarquezp diegomarquezp requested review from a team as code owners March 24, 2025 15:29
@diegomarquezp diegomarquezp requested a review from shollyman March 24, 2025 15:29
@diegomarquezp
Copy link
Contributor Author

The lint check will fail while the changes from googleapis/java-shared-config#1003 are not in this repo via sdk-platform-config's next release.

@suztomo
Copy link
Member

suztomo commented Mar 24, 2025

The mvn command changed didn't it?

@diegomarquezp
Copy link
Contributor Author

The mvn command changed didn't it?

@suztomo Yes, thanks for the catch! Fixed in 6abcfbf

@suztomo
Copy link
Member

suztomo commented Mar 24, 2025

Great. I see the lint job succeeded.

@diegomarquezp diegomarquezp added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 25, 2025
@diegomarquezp
Copy link
Contributor Author

diegomarquezp commented Mar 25, 2025

Thanks for the review. I'm however adding do not merge as we plan to make the hermetic build docker image to take care of these updates.

@diegomarquezp
Copy link
Contributor Author

BigQuery is not handled by hermetic build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants