-
Notifications
You must be signed in to change notification settings - Fork 180
Open
Labels
api: bigtableIssues related to the googleapis/java-bigtable-hbase API.Issues related to the googleapis/java-bigtable-hbase API.
Description
These calls to OneOf setters in BigtableTableAdminClientWrapper.java overwrite previously set values:
Line 240 in d3403e1
| .setRowKeyPrefix(rowKeyPrefix) |
Line 258 in d3403e1
| .setRowKeyPrefix(rowKeyPrefix) |
This was noticed because of an Error Prone static check, which reports the following error for that code:
src/main/java/com/google/cloud/bigtable/grpc/BigtableTableAdminClientWrapper.java:240: error: [RedundantSetterCall] The oneof `Target` (set via setDeleteAllDataFromTable, setRowKeyPrefix) was called twice with . Setting the same field multiple times is redundant, and could mask a bug.
.setRowKeyPrefix(rowKeyPrefix)
^
(see https://errorprone.info/bugpattern/RedundantSetterCall)
src/main/java/com/google/cloud/bigtable/grpc/BigtableTableAdminClientWrapper.java:258: error: [RedundantSetterCall] The oneof `Target` (set via setDeleteAllDataFromTable, setRowKeyPrefix) was called twice with . Setting the same field multiple times is redundant, and could mask a bug.
.setRowKeyPrefix(rowKeyPrefix)
^
(see https://errorprone.info/bugpattern/RedundantSetterCall)
Metadata
Metadata
Assignees
Labels
api: bigtableIssues related to the googleapis/java-bigtable-hbase API.Issues related to the googleapis/java-bigtable-hbase API.