Skip to content

Conversation

@suztomo
Copy link
Member

@suztomo suztomo commented Oct 5, 2023

The maven-compiler-plugin configuration is already defined in
the shared config pom.xml. This project does not need to declare
the plugin and its configuration.
https://github.com/googleapis/java-shared-config/blob/778a547a09de71dbf9e5a42b155f12d15c319864/pom.xml#L738

The maven-compiler-plugin configuration is already defined in
the shared config pom.xml. This project does not need to declare
the plugin and its configuration.
https://github.com/googleapis/java-shared-config/blob/778a547a09de71dbf9e5a42b155f12d15c319864/pom.xml#L738
@suztomo suztomo requested review from a team as code owners October 5, 2023 13:52
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Oct 5, 2023
@suztomo suztomo marked this pull request as draft October 5, 2023 13:52
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/java-pubsub API. label Oct 5, 2023
suztomo added a commit to suztomo/java-pubsub that referenced this pull request Oct 5, 2023
…p/templates/java_library/.kokoro (googleapis#1761) (googleapis#1478)

* build(deps): bump cryptography

Bumps [cryptography](https://github.com/pyca/cryptography) from 38.0.3 to 39.0.1.
- [Release notes](https://github.com/pyca/cryptography/releases)
- [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst)
- [Commits](pyca/cryptography@38.0.3...39.0.1)

---
updated-dependencies:
- dependency-name: cryptography
  dependency-type: indirect
...



* chore: disabling dependabot

---------





Source-Link: googleapis/synthtool@0c6f8d4
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:5ee35ee919254a3d1e7d4f8abbf1b8c8869ade317ceb2e4df709af1b4b3e9ca1

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tomo Suzuki <[email protected]>
Co-authored-by: ddixit14 <[email protected]>
@suztomo
Copy link
Member Author

suztomo commented Oct 5, 2023

It failed.

Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile (default-compile) on project google-cloud-pubsub: Compilation failure
Error:  /home/runner/work/java-pubsub/java-pubsub/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/SubscriberStats.java:[57,41] package AutoValue_SubscriberStats does not exist
Error:  -> [Help 1]

@suztomo
Copy link
Member Author

suztomo commented Oct 5, 2023

The shared config has a strange setup to check EnableAutoValue.txt file.

    <profile>
      <id>autovalue-java8</id>
      <activation>
        <jdk>[1.8,)</jdk>
        <file>
          <exists>${basedir}/EnableAutoValue.txt</exists>
        </file>
      </activation>
      <build>
        <plugins>
          <plugin>
            <artifactId>maven-compiler-plugin</artifactId>
            <configuration>
              <annotationProcessorPaths>
                <path>
                  <groupId>com.google.auto.value</groupId>
                  <artifactId>auto-value</artifactId>
                  <version>${auto-value-annotation.version}</version>
                </path>
...

The profile is then only active if all conditions are met

https://maven.apache.org/guides/introduction/introduction-to-profiles.html#multiple-conditions

@suztomo
Copy link
Member Author

suztomo commented Oct 5, 2023

It failed again. https://github.com/googleapis/java-pubsub/actions/runs/6420127119/job/17431538139?pr=1761 Now I'm moving the file to google-cloud-pubsub directory.

@suztomo suztomo marked this pull request as ready for review October 5, 2023 14:25
@suztomo suztomo added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 5, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 5, 2023
@suztomo suztomo added the automerge Merge the pull request once unit tests and other checks pass. label Oct 5, 2023
@suztomo suztomo added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 5, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 5, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 3d9b19c into googleapis:main Oct 5, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 5, 2023
@suztomo suztomo deleted the remove_autovalue_reference branch October 5, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the googleapis/java-pubsub API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants