fix: use require to load proto JSON #1283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: pubsub
Codecov Report
@@ Coverage Diff @@
## master #1283 +/- ##
==========================================
- Coverage 97.84% 97.84% -0.01%
==========================================
Files 26 26
Lines 12700 12738 +38
Branches 558 605 +47
==========================================
+ Hits 12426 12463 +37
- Misses 268 269 +1
Partials 6 6
Continue to review full report at Codecov.
|
feywind
approved these changes
May 10, 2021
feywind
pushed a commit
to feywind/nodejs-pubsub
that referenced
this pull request
Nov 12, 2024
* Make the mock server test async This test uses the done callback which looks confusing. We should. make the test async for readability. * test: Make the mock server test async * Remove the unnecessary before block The service does not need to be initialized in a before block. Move it to where the server is initialized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1246.
Regenerating the code using gapic-generator-typescript v1.3.2. The main change is introduced in googleapis/gapic-generator-typescript#861. The generated proto changes are related to the changes in oneof field default values (that should be unset), that was introduced by protobufjs/protobuf.js#1597 and is unrelated to the proto JSON
requireproblem.