Skip to content

Conversation

@parthea
Copy link
Collaborator

@parthea parthea commented Oct 28, 2025

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Oct 28, 2025
@parthea parthea force-pushed the remove-dep-packaging-pkg-resources branch 3 times, most recently from 3e6c40a to d75131c Compare October 28, 2025 18:37
@parthea parthea force-pushed the remove-dep-packaging-pkg-resources branch from d75131c to 603d528 Compare October 28, 2025 18:38
@parthea parthea changed the title [WIP] fix: remove dependency on packaging and pkg_resources fix: remove dependency on packaging and pkg_resources Oct 28, 2025
@parthea parthea marked this pull request as ready for review October 28, 2025 18:52
@parthea parthea requested review from a team as code owners October 28, 2025 18:52
daniel-sanche
daniel-sanche previously approved these changes Oct 28, 2025
@daniel-sanche daniel-sanche added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 28, 2025
@daniel-sanche
Copy link
Contributor

added do not merge label so Victor can take a look

@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 28, 2025
@parthea parthea merged commit ca59a86 into main Oct 28, 2025
50 checks passed
@parthea parthea deleted the remove-dep-packaging-pkg-resources branch October 28, 2025 20:57
arvados-bot pushed a commit to arvados/arvados that referenced this pull request Oct 29, 2025
The real purpose of this commit is to force packages to rebuild with a
new version of googleapiclient to get the fix from
<googleapis/python-api-core#852>.
No issue #.

Arvados-DCO-1.1-Signed-off-by: Brett Smith <[email protected]>
pujawadare pushed a commit to pujawadare/python-api-core that referenced this pull request Oct 30, 2025
* fix: remove dependency on packaging and pkg_resources

* add test case

* lint

* update docstring

* add constraint for importlib_metadata

* address feedback

* address feedback

* remove comment

* address feedback

* address feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

google-cloud-secret-manager is missing the module packaging ModuleNotFoundError: No module named 'packaging'

6 participants