-
Notifications
You must be signed in to change notification settings - Fork 62
feat: use EUC for AI generation functions when connection_id is not present #2272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
tswast
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doctest failures appear to be related
FAILED bigframes/bigquery/_operations/ai.py::bigframes.bigquery._operations.ai.generate
FAILED bigframes/bigquery/_operations/ai.py::bigframes.bigquery._operations.ai.generate_bool
FAILED bigframes/bigquery/_operations/ai.py::bigframes.bigquery._operations.ai.generate_double
FAILED bigframes/bigquery/_operations/ai.py::bigframes.bigquery._operations.ai.generate_int
Yeah those look like permission failures. I guess our doc runners don't have EUC permissions for AI functions. |
|
cl/828515544 may be a useful example. that's where I granted the samples tests users permissions. that shouldn't affect doctest, though. doctest should use the compute engine service account from bigframes-dev. |
Would doctest be considered a background job (I'm not very familiar with these setups)? If that's true, then we will need to explicitly provide a connection_id too 🧐. |
|
Do not merge this PR until related failures in doc tests and notebook tests are gone |
Fixes #460856043 🦕