Skip to content

Conversation

@sycai
Copy link
Contributor

@sycai sycai commented Nov 14, 2025

Fixes #460856043 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Nov 14, 2025
@sycai sycai changed the title Sycai ai gen euc feat: use EUC for AI generation functions when connection_id is not present Nov 14, 2025
@sycai sycai marked this pull request as ready for review November 14, 2025 23:28
@sycai sycai requested review from a team as code owners November 14, 2025 23:28
@sycai sycai requested a review from chelsea-lin November 14, 2025 23:28
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doctest failures appear to be related

FAILED bigframes/bigquery/_operations/ai.py::bigframes.bigquery._operations.ai.generate
FAILED bigframes/bigquery/_operations/ai.py::bigframes.bigquery._operations.ai.generate_bool
FAILED bigframes/bigquery/_operations/ai.py::bigframes.bigquery._operations.ai.generate_double
FAILED bigframes/bigquery/_operations/ai.py::bigframes.bigquery._operations.ai.generate_int

@sycai
Copy link
Contributor Author

sycai commented Nov 14, 2025

doctest failures appear to be related

FAILED bigframes/bigquery/_operations/ai.py::bigframes.bigquery._operations.ai.generate
FAILED bigframes/bigquery/_operations/ai.py::bigframes.bigquery._operations.ai.generate_bool
FAILED bigframes/bigquery/_operations/ai.py::bigframes.bigquery._operations.ai.generate_double
FAILED bigframes/bigquery/_operations/ai.py::bigframes.bigquery._operations.ai.generate_int

Yeah those look like permission failures. I guess our doc runners don't have EUC permissions for AI functions.

@tswast
Copy link
Collaborator

tswast commented Nov 14, 2025

cl/828515544 may be a useful example. that's where I granted the samples tests users permissions. that shouldn't affect doctest, though. doctest should use the compute engine service account from bigframes-dev.

@sycai
Copy link
Contributor Author

sycai commented Nov 15, 2025

cl/828515544 may be a useful example. that's where I granted the samples tests users permissions. that shouldn't affect doctest, though. doctest should use the compute engine service account from bigframes-dev.

Would doctest be considered a background job (I'm not very familiar with these setups)? If that's true, then we will need to explicitly provide a connection_id too 🧐.

@sycai sycai added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 15, 2025
@sycai
Copy link
Contributor Author

sycai commented Nov 15, 2025

Do not merge this PR until related failures in doc tests and notebook tests are gone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants