-
Notifications
You must be signed in to change notification settings - Fork 46
feat: introduce compatibility with native namespace packages #706
feat: introduce compatibility with native namespace packages #706
Conversation
|
There is an upcoming release freeze. This should be merged after the release freeze ends on November 29th. |
parthea
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please could you also remove usage of pkg_resources here? Please feel free to make the change in this PR or a separate PR. This should allow us to close #482
| import pkg_resources |
b47238d to
a85ddca
Compare
Edit: Will be done in this PR |
parthea
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added minor observations. Otherwise LGTM
parthea
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to migrate setup.py to use setuptoolsfind_namespace_packages(.. instead of setuptools.PEP420PackageFinder.find()
This PR:
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #705 🦕