Skip to content

Conversation

@chalmerlowe
Copy link
Collaborator

This PR creates a new configuration file in the .kokoro/presubmit folder.
The intent is to eventually move multiple checks out of the baseline Kokoro check and put them into their own Kokoro linting-typing:

The checks we are moving out include:

Typing:

  • mypy
  • mypy_samples
  • pytype

Linting/formatting:

  • lint
  • lint_setup_py
  • blacken

@chalmerlowe chalmerlowe requested review from a team as code owners March 29, 2024 11:19
@chalmerlowe chalmerlowe requested a review from PhongChuong March 29, 2024 11:19
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Mar 29, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Mar 29, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Mar 29, 2024
@chalmerlowe
Copy link
Collaborator Author

chalmerlowe commented Mar 29, 2024

There is an internal Google CL (#618137967) to update the allowed env vars for this repository.
Once that gets approved, we should be able to confirm that this PR runs and determine what, if any time-savings are achieved by parallelizing these tests.

Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for simplifying this a bit!

@chalmerlowe chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 29, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 29, 2024
Copy link
Collaborator Author

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the comments.

@chalmerlowe chalmerlowe added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 2, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 2, 2024
@chalmerlowe chalmerlowe added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 2, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 2, 2024
@chalmerlowe chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 2, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants