tests: System/compatibility tests for testing shim compatiblity #1218
+832
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigtable
| env_vars: { | ||
| key: "NOX_SESSION" | ||
| value: "system-3.12" | ||
| } No newline at end of file |
There was a problem hiding this comment.
I pulled in main, so this shouldn't be necessary anymore
| self._row_merger = _RowMerger(self._row_merger.last_seen_row_key) | ||
| self.response_iterator = self.read_method(retry_request) | ||
| self.response_iterator = self.read_method(retry_request, retry=self.retry) | ||
|
|
There was a problem hiding this comment.
why was this change needed?
| class SelectiveMethodsErrorInjector(UnaryStreamClientInterceptor): | ||
| def __init__(self): | ||
| # As long as there are more items on this list, the items on the list | ||
| # are as follows: |
There was a problem hiding this comment.
I assume after the list is exhausted, it always behaves as normal?
| data_table, rows_to_delete, row_keys, columns, CELL_VAL_READ_ROWS_RETRY | ||
| ) | ||
|
|
||
| yield data_table |
There was a problem hiding this comment.
Isn't this re-populating the table before each test function? Is that necessary?
|
|
||
|
|
||
| def _populate_table(data_table, rows_to_delete, row_keys): | ||
| def _add_test_error_handler(retry): |
There was a problem hiding this comment.
a docstring could be helpful here
It looks like it overrides the on_error function to assert that backoff values are within expected bounds?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional system tests for testing shim compatibility with the classic client interface.
Also fixes a bug where encountering a retriable error after another retriable error mid-stream raised an exception instead of retrying.