feat: use limited API to build PyPI wheels #254
+39
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Python 3.13 was published a little over a week ago. Can we get eyes on this PR? |
|
@vchudnov-g can this be merged? Thanks! |
|
This is a fantastic idea @mayeut and will save headaches with every new Python version. I do hope it gets merged soon. |
TheCrazyLex
approved these changes
Feb 19, 2025
benglewis
reviewed
Mar 6, 2025
andrewsg
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
parthea
added
kokoro:force-run
yoshi-kokoro
removed
kokoro:run
parthea
added
kokoro:force-run
yoshi-kokoro
removed
kokoro:run
jlaine
reviewed
Mar 28, 2025
| CRC32C_PURE_PYTHON_EXPLICIT = "CRC32C_PURE_PYTHON" in os.environ | ||
| _FALSE_OPTIONS = ("0", "false", "no", "False", "No", None) | ||
| CRC32C_PURE_PYTHON = os.getenv("CRC32C_PURE_PYTHON") not in _FALSE_OPTIONS | ||
| # Wether or not we want to build using limited API (ABI3) |
|
Any chance of revisiting this PR? It would have given us Python 3.14 compatible wheels for free :) |
|
No promises, but let me see what I can do. Gonna let the kokoro checks run and then see if we can move this forward for everything including 3.14. |
|
Python 3.14 is released and my CI is spammed with hundreds of copies of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was mentioned in #178, might as well propose something.
Mitigates #178