Skip to content

Conversation

@gcf-owl-bot
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Dec 1, 2021

No description provided.

Source-Link: googleapis/synthtool@6b5cee7
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:74124fe59b8859f30143dcdea7b78300046d97de816dc53c0e381308a5f4f8bc
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners December 1, 2021 17:14
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 1, 2021
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Dec 1, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 1, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 1, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 1, 2021
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@plamut This PR is undoing your work on mypy -- maybe you need to update owlbot.py?

@tseaver tseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 1, 2021
@tseaver tseaver changed the title chore: keep beta version intact DO NOT MERGE: revert local changes to mypy Dec 1, 2021
@parthea
Copy link
Contributor

parthea commented Dec 2, 2021

Owlbot did not run on PR #542 . Moving forward, we could solve this issue by making owl bot a required check on all PRs. @plamut , please could you update owlbot.py ?

@plamut
Copy link
Contributor

plamut commented Dec 2, 2021

Ah, the noxfile is autogenerated in Pub/Sub, thanks for the notice (it's hand-written in BigQuery where I did the similar type hints task recently, which mislead me here).

Sure, I will add the necessary changes to owlbot.py.

Moving forward, we could solve this issue by making owl bot a required check on all PRs.

Now that the transition has been completed and the process is more or less stable, I think that would make sense. Contributors will then quickly see if any of their manual changes get overwritten by the bot.

@plamut plamut mentioned this pull request Dec 2, 2021
@plamut
Copy link
Contributor

plamut commented Dec 2, 2021

Not relevant anymore, the changes that the bot wanted to undo here were persisted in #545

@plamut plamut closed this Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the googleapis/python-pubsub API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing. owl-bot-update-lock

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants