Skip to content

process: persist mypy session in noxfile #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 2, 2021
Merged

process: persist mypy session in noxfile #546

merged 5 commits into from
Dec 2, 2021

Conversation

@plamut
Copy link
Contributor

@plamut plamut commented Dec 2, 2021

Fixes #545.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 2, 2021
@plamut plamut requested a review from parthea December 2, 2021 09:37
@plamut plamut requested review from a team as code owners December 2, 2021 09:37
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 2, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 2, 2021
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Dec 2, 2021
@plamut plamut added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 2, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 2, 2021
@plamut plamut added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 2, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 2, 2021
@plamut plamut added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 2, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 2, 2021
@plamut plamut merged commit 0694bd4 into googleapis:main Dec 2, 2021
@plamut plamut deleted the persist-nox-mypy branch December 2, 2021 10:36
@plamut
Copy link
Contributor Author

plamut commented Dec 2, 2021

Thanks for the quick review, @parthea !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parthea parthea parthea approved these changes

Assignees

No one assigned

Labels

api: pubsub Issues related to the googleapis/python-pubsub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Persist mypy nox session

2 participants

@plamut @parthea