Skip to content

Conversation

@IlyaFaer
Copy link
Contributor

@IlyaFaer IlyaFaer commented Sep 9, 2021

@IlyaFaer IlyaFaer added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Sep 9, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 9, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Sep 9, 2021
@IlyaFaer IlyaFaer marked this pull request as ready for review September 9, 2021 15:39
@IlyaFaer IlyaFaer requested a review from a team as a code owner September 9, 2021 15:39
@IlyaFaer IlyaFaer requested a review from skuruppu September 9, 2021 15:39
@larkee larkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 9, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 9, 2021
@skuruppu skuruppu added the automerge Merge the pull request once unit tests and other checks pass. label Sep 9, 2021
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 10, 2021
@IlyaFaer IlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 10, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 10, 2021
@larkee larkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 10, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 10, 2021
@IlyaFaer
Copy link
Contributor Author

IlyaFaer commented Sep 10, 2021

A couple of sample tests failed with google.api_core.exceptions.RetryError: Deadline of 240.0s exceeded - doesn't seem to be related

@larkee larkee merged commit b5f977e into googleapis:main Sep 13, 2021
@IlyaFaer IlyaFaer deleted the user_agent branch September 13, 2021 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: set user-agent string to distinguish SQLAlchemy requests

4 participants