feat: Inline Begin transction for RW transactions #840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
surbhigarg92
force-pushed
the
inline_begintransaction
branch
from
fc55e91 to
d06c593
Compare
surbhigarg92
changed the title
product-auto-label
bot
added
size: xl
asthamohta
reviewed
Dec 6, 2022
larkee
requested changes
Dec 7, 2022
asthamohta
reviewed
Dec 7, 2022
asthamohta
reviewed
Dec 7, 2022
asthamohta
reviewed
Dec 7, 2022
asthamohta
reviewed
Dec 7, 2022
surbhigarg92
force-pushed
the
inline_begintransaction
branch
2 times, most recently
from
4bfa075 to
3a002c4
Compare
larkee
reviewed
Dec 12, 2022
Co-authored-by: larkee <[email protected]>
Co-authored-by: larkee <[email protected]>
asthamohta
approved these changes
Dec 12, 2022
larkee
approved these changes
Dec 13, 2022
Contributor
larkee
left a comment
larkee
left a comment
There was a problem hiding this comment.
LGTM, just a few style nits 👍
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Dec 15, 2022
🤖 I have created a release *beep* *boop* --- ## [3.26.0](https://togithub.com/googleapis/python-spanner/compare/v3.25.0...v3.26.0) (2022-12-15) ### Features * Inline Begin transction for RW transactions ([#840](https://togithub.com/googleapis/python-spanner/issues/840)) ([c2456be](https://togithub.com/googleapis/python-spanner/commit/c2456bed513dc4ab8954e5227605fca12e776b63)) ### Bug Fixes * Fix for binding of pinging and bursty pool with database role ([#871](https://togithub.com/googleapis/python-spanner/issues/871)) ([89da17e](https://togithub.com/googleapis/python-spanner/commit/89da17efccdf4f686f73f87f997128a96c614839)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.