Skip to content

Conversation

JoeWang1127
Copy link
Contributor

b/323979063

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Feb 9, 2024
@JoeWang1127 JoeWang1127 requested a review from alicejli February 9, 2024 18:56
@JoeWang1127 JoeWang1127 marked this pull request as ready for review February 9, 2024 18:56
@JoeWang1127 JoeWang1127 requested a review from a team as a code owner February 9, 2024 18:56
@ddixit14
Copy link
Contributor

ddixit14 commented Feb 9, 2024

Hey, can we hold off merging this in till #2433 is approved by Blake? By that time we will definitely finalize the dependencies that need to be added. cc @suztomo @blakeli0 .

@suztomo
Copy link
Member

suztomo commented Feb 12, 2024

@ddixit14 What are Maven artifacts coordinates that may be added more for your case?

java-spanner check is now failing because the shared dependencies BOM does not have the two artifacts in the shared dependencies BOM. googleapis/java-spanner#2878 . The quick and proper solution is to merge this 2456. You can always create a request when it's ready.

@ddixit14
Copy link
Contributor

Thank you @suztomo, I will create a new request when the dependencies are finalized.

@suztomo suztomo added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 12, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 12, 2024
@alicejli alicejli enabled auto-merge (squash) February 13, 2024 18:53
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@alicejli alicejli merged commit 728e63d into main Feb 13, 2024
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@alicejli alicejli deleted the chore/add-opentelemtry branch February 13, 2024 19:08
ddixit14 pushed a commit that referenced this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants