Skip to content

chore: Add script to automate PR merging #3921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

chore: Add script to automate PR merging #3921

wants to merge 6 commits into from

Conversation

jinseopkim0
Copy link
Contributor

This script automates the process of retrying and merging pull requests by checking the status of Kokoro tests.

@jinseopkim0
feat: Add script to automate PR merging
3b8c112 
This script automates the process of retrying and merging pull requests by checking the status of Kokoro tests.
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Oct 2, 2025
@jinseopkim0 jinseopkim0 requested a review from mpeddada1 October 2, 2025 18:02
mpeddada1
mpeddada1 reviewed Oct 3, 2025
View reviewed changes
@blakeli0
Copy link
Collaborator

blakeli0 commented Oct 3, 2025

For helper scripts, we usually use chore instead of feat, otherwise it would show up in release notes.

@jinseopkim0 jinseopkim0 changed the title feat: Add script to automate PR merging chore: Add script to automate PR merging Oct 3, 2025
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Oct 3, 2025
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Oct 3, 2025
@jinseopkim0
Copy link
Contributor Author

/gcbrun

@jinseopkim0
Copy link
Contributor Author

/gcbrun

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 3, 2025

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 3, 2025

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@blakeli0
Copy link
Collaborator

blakeli0 commented Oct 3, 2025

Do you mind adding example usage to the description and script itself? I guess it need some pre-requisite as well, for example Go to be installed etc.?

@blakeli0
Copy link
Collaborator

blakeli0 commented Oct 3, 2025

Regarding the location of the scripts, I think google-cloud-java might be a better place, instead of sdk-platform-java. There are actually no kokoro integration tests in sdk-platform-java.

@jinseopkim0
Copy link
Contributor Author

Regarding the location of the scripts, I think google-cloud-java might be a better place, instead of sdk-platform-java. There are actually no kokoro integration tests in sdk-platform-java.

Thanks for the feedback, created googleapis/google-cloud-java#11758 to put the script in google-cloud-java.

@jinseopkim0 jinseopkim0 closed this Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpeddada1 mpeddada1 mpeddada1 approved these changes

@blakeli0 blakeli0 Awaiting requested review from blakeli0

Assignees
No one assigned
Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jinseopkim0 @blakeli0 @mpeddada1