-
Notifications
You must be signed in to change notification settings - Fork 11
doc: add import from conan #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
doc/conan.md
Outdated
|
||
### 1. All `cflags` Included by Default | ||
|
||
The automatically generated `llcpp.cfg` includes all header files from dependencies listed under `cflags`. For example, `libxml2` includes header files from `zlib`, and `libxslt` includes headers from both `libxml2` and `zlib` as part of its include paths. This behavior is unintended — for example, in certain cases, headers from `libxml2` and `zlib` need to be removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
llcpp.cfg
-> llcppg.cfg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in cc6fd24
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #277 +/- ##
=======================================
Coverage 80.07% 80.07%
=======================================
Files 28 28
Lines 2951 2951
=======================================
Hits 2363 2363
Misses 571 571
Partials 17 17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
||
Remove `lib` prefix. | ||
|
||
However, this may cause naming conflicts and needs to be verified. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recipes
from https://github.com/conan-io/conan-center-index with these verify program,found these package will have conflict
package main
import (
"fmt"
"os"
"strings"
)
func main() {
names := make(map[string][]string)
dirs, err := os.ReadDir("./recipes")
if err != nil {
panic(err)
}
for _, pkg := range dirs {
if pkg.IsDir() {
pkgnoLib := strings.TrimPrefix(pkg.Name(), "lib")
names[pkgnoLib] = append(names[pkgnoLib], pkg.Name())
}
}
for name, pkgs := range names {
if len(pkgs) > 1 {
fmt.Println(name, pkgs)
}
}
}
❯ go run main.go
tar [libtar tar]
serial [libserial serial]
vdpau [libvdpau vdpau]
b2 [b2 libb2]
gettext [gettext libgettext]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MeteorsLiu i open a pr for this verification MeteorsLiu#1, need review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 4f3d04a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conanfile.py package_type to filter binary or libary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4f3d04a
to
bad5f31
Compare
|
||
The automatically generated `llcppg.cfg` includes all header files from dependencies listed under `cflags`. For example, `libxml2` includes header files from `zlib`, and `libxslt` includes headers from both `libxml2` and `zlib` as part of its include paths. This behavior is unintended — for example, in certain cases, headers from `libxml2` and `zlib` need to be removed. | ||
|
||
**Preliminary solution:** Automatically remove them during dependency population. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note:need support custom llpkg
|
||
Batch conversion cannot perform demo validation. | ||
|
||
**Preliminary solution:** Use basic `llgo build` validation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
valid compile
order by popular |
[Git-flow] Hi @MeteorsLiu, There are some suggestions for your information: Rebase suggestions
Which seems insignificant, recommend to use For other If you have any questions about this comment, feel free to raise an issue here: |
No description provided.