Skip to content

Conversation

MeteorsLiu
Copy link
Contributor

No description provided.

doc/conan.md Outdated

### 1. All `cflags` Included by Default

The automatically generated `llcpp.cfg` includes all header files from dependencies listed under `cflags`. For example, `libxml2` includes header files from `zlib`, and `libxslt` includes headers from both `libxml2` and `zlib` as part of its include paths. This behavior is unintended — for example, in certain cases, headers from `libxml2` and `zlib` need to be removed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

llcpp.cfg -> llcppg.cfg

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in cc6fd24

Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.07%. Comparing base (91455f6) to head (f809b77).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #277   +/-   ##
=======================================
  Coverage   80.07%   80.07%           
=======================================
  Files          28       28           
  Lines        2951     2951           
=======================================
  Hits         2363     2363           
  Misses        571      571           
  Partials       17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.


Remove `lib` prefix.

However, this may cause naming conflicts and needs to be verified.
Copy link
Member

@luoliwoshang luoliwoshang Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recipes from https://github.com/conan-io/conan-center-index with these verify program,found these package will have conflict

package main

import (
	"fmt"
	"os"
	"strings"
)

func main() {
	names := make(map[string][]string)
	dirs, err := os.ReadDir("./recipes")
	if err != nil {
		panic(err)
	}
	for _, pkg := range dirs {
		if pkg.IsDir() {
			pkgnoLib := strings.TrimPrefix(pkg.Name(), "lib")
			names[pkgnoLib] = append(names[pkgnoLib], pkg.Name())
		}
	}
	for name, pkgs := range names {
		if len(pkgs) > 1 {
			fmt.Println(name, pkgs)
		}
	}
}
❯ go run main.go
tar [libtar tar]
serial [libserial serial]
vdpau [libvdpau vdpau]
b2 [b2 libb2]
gettext [gettext libgettext]

Copy link
Member

@luoliwoshang luoliwoshang Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MeteorsLiu i open a pr for this verification MeteorsLiu#1, need review

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 4f3d04a

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conanfile.py package_type to filter binary or libary

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MeteorsLiu MeteorsLiu force-pushed the doc/import-from-conan branch from 4f3d04a to bad5f31 Compare April 27, 2025 01:56

The automatically generated `llcppg.cfg` includes all header files from dependencies listed under `cflags`. For example, `libxml2` includes header files from `zlib`, and `libxslt` includes headers from both `libxml2` and `zlib` as part of its include paths. This behavior is unintended — for example, in certain cases, headers from `libxml2` and `zlib` need to be removed.

**Preliminary solution:** Automatically remove them during dependency population.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note:need support custom llpkg


Batch conversion cannot perform demo validation.

**Preliminary solution:** Use basic `llgo build` validation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

valid compile

@luoliwoshang
Copy link
Member

order by popular

Copy link

qiniu-x bot commented May 6, 2025

[Git-flow] Hi @MeteorsLiu, There are some suggestions for your information:


Rebase suggestions

  • Following commits seems generated via git merge

    Merge branch 'main' of https://github.com/goplus/llcppg into doc/import-from-conan

    Merge remote-tracking branch 'llcppg/main' into doc/import-from-conan

    Merge remote-tracking branch 'llcppg/main' into doc/import-from-conan

  • Following commits have duplicated messages

    Merge remote-tracking branch 'llcppg/main' into doc/import-from-conan

    Merge remote-tracking branch 'llcppg/main' into doc/import-from-conan

Which seems insignificant, recommend to use git rebase command to reorganize your PR.

For other git-flow instructions, recommend refer to these examples.

If you have any questions about this comment, feel free to raise an issue here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants