fix: make vars capital in smoke tests #738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change in gptscript got rid of the lowercase env vars because they don't work on Windows. This change updates the smoke tests. Signed-off-by: Donnie Adams <[email protected]>
thedadams
requested review from
StrongMonkey,
drpebcak,
g-linville,
njhale and
tylerslaton
StrongMonkey
approved these changes
Aug 7, 2024
njhale
approved these changes
Aug 7, 2024
drpebcak
reviewed
Aug 7, 2024
| args: question: The question to ask Bob. | ||
|
|
||
| When asked how I am doing, respond with exactly "Thanks for asking "${question}", I'm doing great fellow friendly AI tool!" | ||
| When asked how I am doing, respond with exactly "Thanks for asking "${QUESTION}", I'm doing great fellow friendly AI tool!" |
There was a problem hiding this comment.
I see this was merged already but as a point of interest, this is not really an env var - this tool is not a 'code tool', so this interpolation syntax is really just there as a hint for the llm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change in gptscript got rid of the lowercase env vars because they don't work on Windows. This change updates the smoke tests.