[23.1] Backport: Fix native-image build with --no-jlinking

[zakkak]

What would you like to backport?

oracle#7205

Why?

To get the same upstream patch in our release instead of using our own.

Are the changes being backported merged in upstream Graal?

• Yes
• No

[github-actions]

This issue appears to be stale because it has been open 30 days with no activity. This issue will be closed in 7 days unless Stale label is removed, a new comment is made, or not-Stale label is added.

[jerboaa]

The 24.0 change depends on oracle#7454 so if we are going to backport oracle#7205 verbatim, we need to backport oracle#7454 first.

[zakkak]

@jerboaa, given the size and touch-area of oracle#7454 I am thinking about sticking to our original backport in 588ae3a. WDYT?

[jerboaa]

@jerboaa, given the size and touch-area of oracle#7454 I am thinking about sticking to our original backport in 588ae3a. WDYT?

@zakkak Given that 23.1 will likely stick around for a longer time, it would be best to backport it (IMO). It gets rid of a java --list-modules call which isn't great currently in 23.1. The earlier we can get it in the 23.1 cycle, the better.

[jerboaa]

I can do the backport if you like.

[zakkak]

I can do the backport if you like.

Sure, please go ahead, since you are more familiar with the code there are more chances of getting it right before me :)

You should have push rights to https://github.com/zakkak/mandrel/tree/2023-12-18-23.1-jan-cpu-backports (#640) by the way (if you want to include it to the existing PR).

[jerboaa]

I can do the backport if you like.

Sure, please go ahead, since you are more familiar with the code there are more chances of getting it right before me :)

OK.

You should have push rights to https://github.com/zakkak/mandrel/tree/2023-12-18-23.1-jan-cpu-backports (#640) by the way (if you want to include it to the existing PR).

Thanks, but I'll create a separate PR. It's a lot easier to review.