Skip to content

New build type that allows testing without maven-deploy-local #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 20, 2023
Merged

New build type that allows testing without maven-deploy-local #577

merged 3 commits into from
Sep 20, 2023

Conversation

zakkak
Copy link
Collaborator

@zakkak zakkak commented Sep 20, 2023

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 20, 2023
@jerboaa
Copy link
Collaborator

jerboaa commented Sep 20, 2023

@zakkak I don't see a difference in the mandrel-source vs mandrel-source-nolocalmvn builds when it comes to a quarkus build. Both seem to skip downloading the mvn artefacts. Thoughts? It looks like the graalvm/mandrel build also doesn't build the local maven bits regardless.

@zakkak
Copy link
Collaborator Author

zakkak commented Sep 20, 2023

Yup, I mistyped the output variable's name as maven-local-deploy instead of maven-deploy-local....

@zakkak zakkak force-pushed the 2023-09-20-ci-work-with-older-versions branch from 4669c9b to 4b9dce4 Compare September 20, 2023 08:56
@zakkak
Copy link
Collaborator Author

zakkak commented Sep 20, 2023 •
edited
Loading

New CI runs:

Update: There's still something wrong

Update2: latest CI runs:

@zakkak zakkak force-pushed the 2023-09-20-ci-work-with-older-versions branch from 4b9dce4 to 34088c5 Compare September 20, 2023 09:19
@jerboaa
Copy link
Collaborator

jerboaa commented Sep 20, 2023 •
edited
Loading

You seem to be building from a release tree, which doesn't include SNAPSHOT and thus, the maven version will be empty (yes, a pre-existing bug). See https://github.com/zakkak/mandrel/actions/runs/6246694144/job/16957799513#step:7:969

We probably need a smarter way to find the version. Maybe just use (assuming the 6'th token is the maven version that mx prints):

set $(head -n1 maven_deploy.log)
MAVEN_VERS=$(echo $6)

instead of:

MAVEN_VERS=$(for token in $(head -n1 maven_deploy.log); do if echo $token | grep -q 'SNAPSHOT'; then echo $token; fi; done)

@zakkak zakkak force-pushed the 2023-09-20-ci-work-with-older-versions branch from 4d67c6e to 9453dd3 Compare September 20, 2023 10:54
@zakkak
Copy link
Collaborator Author

zakkak commented Sep 20, 2023 •
edited
Loading

MAVEN_VERS issue should be fixed with 2eaa444

New CI runs (only for the cases that failed and I patched) :

@zakkak zakkak force-pushed the 2023-09-20-ci-work-with-older-versions branch from 9453dd3 to 2eaa444 Compare September 20, 2023 12:22
jerboaa
jerboaa approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (without the TEMP change to use your branch for base.yml)

@zakkak zakkak force-pushed the 2023-09-20-ci-work-with-older-versions branch from 2eaa444 to 8c840b3 Compare September 20, 2023 18:06
@zakkak zakkak marked this pull request as ready for review September 20, 2023 18:06
@zakkak zakkak added the testing CI and testing related issues and PRs label Sep 20, 2023
@zakkak zakkak merged commit 9fdbdd3 into graalvm:default Sep 20, 2023
@zakkak zakkak deleted the 2023-09-20-ci-work-with-older-versions branch September 20, 2023 18:08
This was referenced Sep 20, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jerboaa jerboaa jerboaa approved these changes

Assignees

No one assigned

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement. testing CI and testing related issues and PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zakkak @jerboaa