Use a classpath jar under Windows #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately, I don't think this will fix the reported issue: we're apparently moving the problem one level down. While it fixes the problem of passing a long classpath to |
This commit introduces a classpath jar, a jar which contains no classes but only a Class-Path manifest entry, so that the classpath to `native-image` is passed this way instead of on the CLI. This would fix the issue of long classpath entries on Windows. Fixes graalvm#85
This commit reworks the fix to use a fat jar instead of a pathing jar to fix the long classpath issue under Windows. The reason is that the `native-image` tool will nevertheless expand the pathing jar classpath on another CLI invocation.
|
Following discussion with @lazar-mitrovic , the implementation was changed to use a fat jar under Windows. This mode can be explicitly disabled. |
Unfortunately, due to different bugs(?) in Maven, we cannot use the shading plugin for tests, and we have to move the test execution to the integration test phase. See https://issues.apache.org/jira/browse/MSHADE-402
lazar-mitrovic
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a classpath jar, a jar which contains no
classes but only a Class-Path manifest entry, so that the classpath
to
native-imageis passed this way instead of on the CLI.This would fix the issue of long classpath entries on Windows.
Fixes #85