Skip to content
This repository was archived by the owner on Aug 19, 2020. It is now read-only.

Conversation

@bamboo
Copy link
Member

@bamboo bamboo commented Dec 12, 2017

No description provided.

bamboo and others added 30 commits October 10, 2017 17:27
 - Rename variable for clarity
 - Extract explaining method
Simply check for settings.gradle.kts then settings.gradle.
This code runs in IntelliJ and cannot rely on Gradle services.

It could, and will, make use of a client side mechanism provided by the
TAPI, see gradle/gradle#1994
Removing the need for duplicated target type matching
in KotlinScriptPlugin
 - DRY Gradle property definitions
It hasn't been necessary for a while now and we can always recover
this code if it becomes useful again.
Also:

 - Rename `targetType` to `type` as _target_ is already in the type
   name
And project.property() in favor of project.objects.property()

Take the opportunity and rename to messageProperty
@bamboo bamboo added the a:chore label Dec 12, 2017
@bamboo bamboo added this to the 0.15.0 milestone Dec 12, 2017
@bamboo bamboo self-assigned this Dec 12, 2017
@bamboo bamboo requested a review from eskatos December 12, 2017 19:36
Copy link
Member

@eskatos eskatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@bamboo bamboo merged commit 99d67fc into master Dec 13, 2017
@bamboo bamboo deleted the bamboo/master/v0.13.1 branch February 1, 2018 16:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants