This repository was archived by the owner on Aug 19, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 432
Merge v0.13.1 into master and upgrade wrappers to Gradle 4.4 #628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename variable for clarity
- Extract explaining method
for resolving build roots.
Simply check for settings.gradle.kts then settings.gradle. This code runs in IntelliJ and cannot rely on Gradle services. It could, and will, make use of a client side mechanism provided by the TAPI, see gradle/gradle#1994
Removing the need for duplicated target type matching in KotlinScriptPlugin
- DRY Gradle property definitions
It hasn't been necessary for a while now and we can always recover this code if it becomes useful again.
Also: - Rename `targetType` to `type` as _target_ is already in the type name
Support `Settings` as a script target
And project.property() in favor of project.objects.property() Take the opportunity and rename to messageProperty
eskatos
approved these changes
Dec 13, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.