This repository was archived by the owner on Aug 19, 2020. It is now read-only.
Let master use Gradle 4.5.1 and Gradle Kotlin DSL 0.14.2 #722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements lazy download of Gradle sources when they are not available. Previously, the Kotlin DSL expected the `all` distribution to be used to provide proper IDE support. If this distribution wasn't used (typically with the wrapper), then navigating to sources wasn't possible. With this commit, if the sources are not available, Gradle will do its best to download the zip of sources and make it available. It does so by creating a temporary configuration that is used to reference the Gradle sources, which are then exploded through a dependency transform, so that the IDE can use them.
... and conform constant case to codebase standards
This commit changes the way we find sources, by only looking into the appropriate repository. If the version is a released version, then we will only look into the `distributions` repository. If it's a snapshot, then we will look into the `distributions-snapshot` repository. However, it's possible that this project depends on a Kotlin DSL custom distribution for which the sources haven't been published. So to make it possible to resolve, we use a version range, ending with the current version, and starting with the previous minor.
Until a new version of the `embedded-kotlin` and `kotlin-dsl` plugins is published.
This reverts commit 628599a.
This reverts commit cf22769.
Until a new version of `kotlin-dsl` is published.
to overcome an upstream breaking change, this commit will be reverted
This commit will be reverted
This reverts commit fd65240.
This reverts commit 4d8cba5.
in favor of ExtensionContainer.extensionsSchema
By no longer sending any plugin requests from non top level script. See gradle/gradle#3759
Release 0.14.2
JLLeitschuh
reviewed
Feb 20, 2018
| } | ||
| configurations["compileClasspath"].files.forEach { | ||
| println(it) |
There was a problem hiding this comment.
Do you want to leave this here?
There was a problem hiding this comment.
This was in v0.14.2 and has been removed on develop since then. Given it's a test I would leave it there yes.
JLLeitschuh
approved these changes
Feb 20, 2018
bamboo
approved these changes
Feb 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.