Skip to content
This repository was archived by the owner on Apr 28, 2025. It is now read-only.

Commit 50c36f9

Browse files
authored
Merge pull request #244 from gouthamve/customise-configmap
Add option to customise the configmap name
2 parents 594e536 + c5b0192 commit 50c36f9

11 files changed

+15
-12
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
* [ENHANCEMENT] Improved blocks storage observability: #237
77
- Cortex / Queries: added bucket index load operations and latency (available only when bucket index is enabled)
88
- Alerts: added "CortexBucketIndexNotUpdated" (bucket index only) and "CortexTenantHasPartialBlocks"
9+
* [ENHANCEMENT] The name of the overrides configmap is now customisable via `$._config.overrides_configmap`. #244
910
* [BUGFIX] Honor configured `per_instance_label` in all panels. #239
1011
* [BUGFIX] `CortexRequestLatency` alert now ignores long-running requests on query-scheduler. #242
1112

cortex/config.libsonnet

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -290,6 +290,8 @@
290290
// These are the defaults.
291291
limits: $._config.overrides.extra_small_user,
292292

293+
overrides_configmap: 'overrides',
294+
293295
overrides: {
294296
extra_small_user:: {
295297
max_series_per_user: 0, // Disabled in favour of the max global limit
@@ -415,7 +417,7 @@
415417
local configMap = $.core.v1.configMap,
416418

417419
overrides_config:
418-
configMap.new('overrides') +
420+
configMap.new($._config.overrides_configmap) +
419421
configMap.withData({
420422
'overrides.yaml': $.util.manifestYaml(
421423
{

cortex/distributor.libsonnet

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@
6060
distributor_deployment:
6161
deployment.new('distributor', 3, [$.distributor_container], $.distributor_deployment_labels) +
6262
$.util.antiAffinity +
63-
$.util.configVolumeMount('overrides', '/etc/cortex'),
63+
$.util.configVolumeMount($._config.overrides_configmap, '/etc/cortex'),
6464

6565
local service = $.core.v1.service,
6666

cortex/flusher-job-blocks.libsonnet

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,6 @@
4444
job.mixin.spec.template.metadata.withLabels({ name: 'flusher' }) +
4545
job.mixin.spec.template.spec.securityContext.withRunAsUser(0) +
4646
job.mixin.spec.template.spec.withTerminationGracePeriodSeconds(300) +
47-
$.util.configVolumeMount('overrides', '/etc/cortex') +
47+
$.util.configVolumeMount($._config.overrides_configmap, '/etc/cortex') +
4848
$.util.podPriority('high'),
4949
}

cortex/flusher-job.libsonnet

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,6 @@
4646
job.mixin.spec.template.metadata.withLabels({ name: 'flusher' }) +
4747
job.mixin.spec.template.spec.securityContext.withRunAsUser(0) +
4848
job.mixin.spec.template.spec.withTerminationGracePeriodSeconds(300) +
49-
$.util.configVolumeMount('overrides', '/etc/cortex') +
49+
$.util.configVolumeMount($._config.overrides_configmap, '/etc/cortex') +
5050
$.util.podPriority('high'),
5151
}

cortex/ingester.libsonnet

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@
106106
statefulSet.mixin.spec.template.spec.withTerminationGracePeriodSeconds(4800) +
107107
statefulSet.mixin.spec.updateStrategy.withType('RollingUpdate') +
108108
$.statefulset_storage_config_mixin +
109-
$.util.configVolumeMount('overrides', '/etc/cortex') +
109+
$.util.configVolumeMount($._config.overrides_configmap, '/etc/cortex') +
110110
$.util.podPriority('high') +
111111
$.util.antiAffinityStatefulSet
112112
else null,
@@ -117,7 +117,7 @@
117117
if $._config.ingester_deployment_without_wal then
118118
deployment.new(name, 3, [$.ingester_container], $.ingester_deployment_labels) +
119119
$.util.antiAffinity +
120-
$.util.configVolumeMount('overrides', '/etc/cortex') +
120+
$.util.configVolumeMount($._config.overrides_configmap, '/etc/cortex') +
121121
deployment.mixin.metadata.withLabels({ name: name }) +
122122
deployment.mixin.spec.withMinReadySeconds(60) +
123123
deployment.mixin.spec.strategy.rollingUpdate.withMaxSurge(0) +

cortex/overrides-exporter.libsonnet

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@
5858
local deployment = $.apps.v1.deployment,
5959
overrides_exporter_deployment:
6060
deployment.new(name, 1, [$.overrides_exporter_container], { name: name }) +
61-
$.util.configVolumeMount('overrides', '/etc/cortex') +
61+
$.util.configVolumeMount($._config.overrides_configmap, '/etc/cortex') +
6262
$.util.configVolumeMount('overrides-presets', '/etc/cortex_presets') +
6363
deployment.mixin.metadata.withLabels({ name: name }),
6464

cortex/querier.libsonnet

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656
querier_deployment:
5757
deployment.new('querier', $._config.querier.replicas, [$.querier_container], $.querier_deployment_labels) +
5858
$.util.antiAffinity +
59-
$.util.configVolumeMount('overrides', '/etc/cortex') +
59+
$.util.configVolumeMount($._config.overrides_configmap, '/etc/cortex') +
6060
$.storage_config_mixin,
6161

6262
local service = $.core.v1.service,

cortex/query-frontend.libsonnet

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@
7070

7171
query_frontend_deployment:
7272
deployment.new('query-frontend', $._config.queryFrontend.replicas, [$.query_frontend_container]) +
73-
$.util.configVolumeMount('overrides', '/etc/cortex') +
73+
$.util.configVolumeMount($._config.overrides_configmap, '/etc/cortex') +
7474
$.util.antiAffinity +
7575
// inject storage schema in order to know what/how to shard
7676
if $._config.queryFrontend.sharded_queries_enabled then

cortex/ruler.libsonnet

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
deployment.mixin.spec.strategy.rollingUpdate.withMaxUnavailable(1) +
4646
deployment.mixin.spec.template.spec.withTerminationGracePeriodSeconds(600) +
4747
$.util.antiAffinity +
48-
$.util.configVolumeMount('overrides', '/etc/cortex') +
48+
$.util.configVolumeMount($._config.overrides_configmap, '/etc/cortex') +
4949
$.storage_config_mixin
5050
else {},
5151

0 commit comments

Comments
 (0)