This repository was archived by the owner on Apr 28, 2025. It is now read-only.
Add option to customise the configmap name #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracucci
approved these changes
Jan 12, 2021
Collaborator
pracucci
left a comment
pracucci
left a comment
There was a problem hiding this comment.
LGTM. Don't forget a CHANGELOG entry.
Signed-off-by: Goutham Veeramachaneni <[email protected]>
gouthamve
force-pushed
the
customise-configmap
branch
from
09dedc6 to
c5b0192
Compare
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Dec 20, 2021
…e-configmap Add option to customise the configmap name
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Goutham Veeramachaneni [email protected]